feat: extract and reuse email field as a separate component #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
|
Forgot to sync my fork, fixing the conflicts in a minute |
ani-kalpachka
added
the
run tests
github-actions
bot
removed
the
run tests
ani-kalpachka
approved these changes
Dec 15, 2022
kachar
approved these changes
Dec 16, 2022
|
Kudos for the upgrade @antonmihaylov 🚀 🚀 |
kachar
pushed a commit
to dimitur2204/podkrepi-frontend
that referenced
this pull request
Dec 19, 2022
dimitur2204
added a commit
that referenced
this pull request
Dec 19, 2022
* 1254 - add campaign title to certificate * 1254 - fix off imports * 1254 - remove Certifacte-en * 1254 - remove unecessary comments * Remove Discord widget bot from the code (#1256) * feat: extract email field as a separate component and reuse it in the forms (#1255) * Improve typing of user session (#1258) * 1129 - Add pagination to donation wishes. (#1252) * 1129 - Add pagination to donation wishes. * 1129 - Check if numOfPages is defined at runtime. * Move pagination to the bottom of the wishes list Co-authored-by: Ilko Kacharov <[email protected]> * Create eslint.yml * Update .all-contributorsrc * Update .all-contributorsrc * Update eslint.yml * Delete eslint.yml * Update 2.feature_request.yml [skip ci] * Update 1.bug_report.yml [skip ci] * Fetch more donation data from api and display it in the pdf * Remove vault name from response type Co-authored-by: Ilko Kacharov <[email protected]> Co-authored-by: Anton Mihaylov <[email protected]> Co-authored-by: Lyoubomir Katzarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted an EmailField component that includes the usual good practices for email fields -
type=email,inputMode="email", andautoComplete="email".Closes #1155
Motivation and context
This makes the forms that use them a bit cleaner and enforces consistency.
Related to: #1120
Testing
Steps to test
The impact of the changes is very small, it's more of a code refactor rather than a feature.
Some things to test are if the login forms don't behave unexpected due to the browser's built-in email validation. I tested that manually and it looks good.
Affected urls
All pages that have an email field
/forgotten-password/campaigns/[slug]/donation/[slug]- the one time donation steps/profileand/profile/[slug]- the update email form in the personal info tab/register/contact/admin/irregularities/createand/admin/irregularities/[id]Environment
New environment variables:
None
New or updated dependencies:
None