1248 - Add locale to stripe return urls #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
dimitur2204
added
area: donations
github-actions
bot
removed
the
run tests
dimitur2204
changed the title
kachar
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Thanks for the contribution @dimitur2204
I was wondering if the default language is recognized when we provide it explicitly. I've tested that and it's all good. ⚙️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1248
Motivation and context
Added the language to the
returnUrlsof the stripe requests.Testing
Tried both failed and success states and they are now translated to the language you had set when you come back.
Steps to test
Go through the donation flow to either succeed or fail.
Affected urls
http://localhost:3040/en/campaigns/donation/:campaignSlug