Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1186 - fix homepage images to now be responsive #1233

Merged

Conversation

dimitur2204
Copy link
Contributor

@dimitur2204 dimitur2204 commented Dec 6, 2022

Closes #1186

Motivation and context

2 images on the homepage were not responsive.
Fixed them as per the examples provided by NextJS
https://github.com/vercel/next.js/blob/canary/examples/image-component/pages/responsive.tsx

Screenshots:

Team Discord
image image

Testing

Tested on all resolutions and images are responsive width width as the viewport until they hit the given widths

Affected urls

index - 'https://podkrepi.bg'

@dimitur2204 dimitur2204 self-assigned this Dec 6, 2022
Copy link
Member

@kachar kachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 Thanks for solving this problem in such a graceful way 🕊️

@kachar kachar merged commit 21e9c05 into podkrepi-bg:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The images on Homepage are not responsive
2 participants