Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated withStyle/makeStyle from Irregularity, Create and Edit forms, Success, Fail and Actions components, Stepper icon #1191

Merged
merged 10 commits into from
Nov 28, 2022
Merged

Remove deprecated withStyle/makeStyle from Irregularity, Create and Edit forms, Success, Fail and Actions components, Stepper icon #1191

merged 10 commits into from
Nov 28, 2022

Conversation

ani-kalpachka
Copy link
Member

@ani-kalpachka ani-kalpachka commented Nov 25, 2022 •
edited
Loading

  • Removed deprecated withStyle/makeStyle for IrregularityForm, Create and Edit forms, Success, Fail and Actions components, Stepper icon.
  • Refactor code, fix responsive styles, remove hardcoded values.
  • Fix action buttons' hover effects.

@ani-kalpachka ani-kalpachka marked this pull request as ready for review November 26, 2022 08:46
@ani-kalpachka ani-kalpachka changed the title Remove deprecated withStyle/makeStyle Remove deprecated withStyle/makeStyle from Irregularity Form, Success and Fail components Nov 26, 2022
@ani-kalpachka ani-kalpachka mentioned this pull request Nov 26, 2022
Closed
@ani-kalpachka ani-kalpachka changed the title Remove deprecated withStyle/makeStyle from Irregularity Form, Success and Fail components Remove deprecated withStyle/makeStyle from Irregularity Form, Success, Fail and Action components Nov 26, 2022
@ani-kalpachka ani-kalpachka changed the title Remove deprecated withStyle/makeStyle from Irregularity Form, Success, Fail and Action components Remove deprecated withStyle/makeStyle from Irregularity Form, Success, Fail and Actions components Nov 26, 2022
@ani-kalpachka ani-kalpachka changed the title Remove deprecated withStyle/makeStyle from Irregularity Form, Success, Fail and Actions components Remove deprecated withStyle/makeStyle from Irregularity, Create and Edit forms, Success, Fail and Actions components Nov 26, 2022
@ani-kalpachka ani-kalpachka marked this pull request as draft November 26, 2022 19:58
@ani-kalpachka ani-kalpachka changed the title Remove deprecated withStyle/makeStyle from Irregularity, Create and Edit forms, Success, Fail and Actions components Remove deprecated withStyle/makeStyle from Irregularity, Create and Edit forms, Success, Fail and Actions components, Stepper icon Nov 26, 2022
@ani-kalpachka ani-kalpachka marked this pull request as ready for review November 26, 2022 20:30
@ani-kalpachka ani-kalpachka linked an issue Nov 26, 2022 that may be closed by this pull request
[Upgrade] Migrate from JSS makeStyles to styled for better MUI 5 #1068
Closed
@ani-kalpachka ani-kalpachka removed a link to an issue Nov 28, 2022
[Upgrade] Migrate from JSS makeStyles to styled for better MUI 5 #1068
Closed
@ani-kalpachka ani-kalpachka linked an issue Nov 28, 2022 that may be closed by this pull request
[Upgrade] Migrate from JSS makeStyles to styled for better MUI 5 #1068
Closed
dimitur2204
dimitur2204 requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@dimitur2204 dimitur2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change requests and amazing job on this tedious task! 🚀

src/components/irregularity/Actions.tsx Outdated Show resolved Hide resolved
src/components/irregularity/helpers/Fail.tsx Outdated Show resolved Hide resolved
src/components/irregularity/helpers/Fail.tsx Outdated Show resolved Hide resolved
src/components/irregularity/helpers/Irregularity.styled.tsx Outdated Show resolved Hide resolved
src/components/irregularity/helpers/Irregularity.styled.tsx Outdated Show resolved Hide resolved
@ani-kalpachka
Copy link
Member Author

ani-kalpachka commented Nov 28, 2022 •
edited
Loading

Small change requests and amazing job on this tedious task! 🚀

@dimitur2204 Thank you for the review and for suggesting these improvements!
I updated the PR.

@kachar kachar merged commit b19d109 into master Nov 28, 2022
@kachar kachar deleted the remove-deprecated-makeStyles branch November 28, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitur2204 dimitur2204 dimitur2204 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Upgrade] Migrate from JSS makeStyles to styled for better MUI 5
3 participants
@ani-kalpachka @dimitur2204 @kachar