Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1145 Upgrade yarn to v3 #1189

Merged
merged 8 commits into from
Nov 25, 2022
Merged

1145 Upgrade yarn to v3 #1189

merged 8 commits into from
Nov 25, 2022

Conversation

kachar
Copy link
Member

@kachar kachar commented Nov 25, 2022

Closes #1145

Motivation and context

  • Yarn documentation
    • Installation (link)
    • Migrate to > 2.x (link)
    • Ignored files (link)
      • In .gitattributes we mark the .yarn/*.cjs files as binary so there are no big diffs when updating
    • Plugins (link)
      • Workspace tools (link)
      • Version (link)
      • Typescript auto-import @types/{package} (link)
    • Configuration using .yarnrc.yml (link)
    • Install production deps only (link)
    • Get cache dir (link)
  • Dockerfile
    • Used NextJS native approach to standalone builds (link)
    • Removed development target and now we only do production builds
    • Removed g++ make python3 from the docker image - we can bring them back if needed

Screenshots:

Before After
Total Image size: 1.1 GB Total Image size: 261 MB
image image

Testing

Steps to test

Yarn:

yarn install

Docker image

Added docker-compose.yml to

docker-compose up --build --no-cache

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
yarn v1.x v3.3.0

@kachar kachar requested a review from imilchev November 25, 2022 12:51
@kachar kachar requested a review from igoychev November 25, 2022 15:12
Copy link
Contributor

@imilchev imilchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing improvement! From my local tests it seems like everything is working. Let's see what happens on dev

@kachar kachar merged commit 618ffcd into master Nov 25, 2022
@kachar kachar deleted the 1145-upgrade-yarn branch November 25, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev] Upgrade yarn to latest
2 participants