Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI stripe webhook #1140

Conversation

imilchev
Copy link
Contributor

Starts stripe webhook before playwright tests

@imilchev imilchev changed the base branch from 1096-tests-automated-ui-e2e-test-for-the-donation-process to master November 20, 2022 18:16
@dimitur2204
Copy link
Contributor

dimitur2204 commented Nov 20, 2022

There are some changes to the donation flow from #1133. I will take a look and change the tests. You can remove the test files from this PR!
You can rebase your changes on top of master

Signed-off-by: Ivan Milchev <[email protected]>
@imilchev
Copy link
Contributor Author

There are some changes to the donation flow from #1133. I will take a look and change the tests. You can remove the test files from this PR! You can rebase your changes on top of master

This PR should merge to #1110 I just haven't updated the base. I can do that now

@imilchev imilchev changed the base branch from master to 1096-tests-automated-ui-e2e-test-for-the-donation-process November 20, 2022 20:00
Copy link
Contributor

@dimitur2204 dimitur2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you might want to wait for @kachar :)

@imilchev
Copy link
Contributor Author

Looks good to me, but you might want to wait for @kachar :)

It's still failing 😆 I am figuring out the stripe permissions this thing needs. After that it should pass and then we can merge it into your branch

@dimitur2204 dimitur2204 merged commit 13b2674 into 1096-tests-automated-ui-e2e-test-for-the-donation-process Nov 21, 2022
@dimitur2204 dimitur2204 deleted the ci-stripe branch November 21, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants