[Feature] Add see more button #1139
Conversation
| <TeamMemberName variant="subtitle1" height={50}> | ||
| {teamMember.name} | ||
| </TeamMemberName> | ||
| <ManagementBoardDescription description={teamMember.description} /> |
There was a problem hiding this comment.
Correct me if I'm wrong, but this seems to be something more like a TeamMemberDescription instead of description for the ManagementBoard? Maybe consider renaming the component so it will fit more with the context behind it :)
| export function ManagementBoardDescription({ description }) { | ||
| const { t } = useTranslation('about') | ||
|
|
||
| const [show, setShow] = useState(false) |
There was a problem hiding this comment.
This is a fairly simple component, but I would suggest to put a bit more descriptive name for this toggle, in case we extend it and add more complicated logic in the future, something like:
isFullDescriptionVisibleisDescriptionCollapsed- etc.
|
Could we not change the shape of the avatars? By designs they are circular. |
|
Related to #1105 |
|
I investigated that the avatars' shape is not caused by these changes - on master they are the same. |
src/components/about/sections/ManagementBoardSection/ManagementBoardDescription.tsx
Outdated
Show resolved
Hide resolved
…tBoardDescription.tsx
Motivation and context
As the members text was too long in order to improve the UX and UI we added See more/less buttons
issue
#1091
Screenshots:
Testing