[Bug] You can click Next if you are both not logged and not anonymous #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitur2204
commented
Nov 20, 2022
| formik.values.isAnonymous = false | ||
| formik.setFieldValue('isAnonymous', false) |
There was a problem hiding this comment.
I suspect the strange behaviour before was coming from either here!
dimitur2204
commented
Nov 20, 2022
Comment on lines
-79
to
+78
| isAnonymous: values?.isAnonymous ?? !isLogged(), | ||
| isAnonymous: values?.isAnonymous !== undefined ? values.isAnonymous : true, |
kachar
reviewed
Nov 20, 2022
| const handleChange = (event: React.SyntheticEvent, newValue: string) => { | ||
| if (Number(newValue) === 3) { |
There was a problem hiding this comment.
@dimitur2204 It's not really clear to me what the constant 3 stands for.
If we're using that as a number of step let's name it in some kind of enum or similar so it brings more context.
Similar to:
if (Number(step) === Steps.Anonymous) {
// ...
}There was a problem hiding this comment.
As I see we can also use names instead of numbers for the tabs.
Ex. logged, newProfile, anonymous 💭
kachar
approved these changes
Nov 20, 2022
There was a problem hiding this comment.
🙌 @dimitur2204 The new flow really simplifies the donation success path
dimitur2204
deleted the
1133-bug-you-can-click-next-if-you-are-both-not-logged-and-not-anonymous
branch
dimitur2204
added a commit
that referenced
this pull request
Nov 21, 2022
…#1134) * 1133 - disable next button when not logged in * 1133 - fix anonymous submit value when mutating * 1133 - add option to be able to donate anonymous even if you are logged in * 1133 - remove console.logs * 1133 - add enum for auth step tabs * 1133 - change Tabs to strings
imilchev
added a commit
that referenced
this pull request
Dec 1, 2022
* 1096 - setup playwright add tests for the first donation step * 1096 - add login page class and global setup * 1096 - add testing for full payment flow of a logged in user * 1096 - remove globalSetup.ts * 1096 - remove auth and change selectors on donation e2e tests * 1096 - add stripe webhook run script to the CI * start stripe webhook before playwright tests Signed-off-by: Ivan Milchev <[email protected]> * remove yarn command for stripe webhook Signed-off-by: Ivan Milchev <[email protected]> * start debugging session Signed-off-by: Ivan Milchev <[email protected]> * record playwright tests Signed-off-by: Ivan Milchev <[email protected]> * adjust stripe secrets Signed-off-by: Ivan Milchev <[email protected]> * Admin can edit donations details imported from bank transfer (#1097) * added: admin can edit donor in donations grid * fixed: edit donor cell visible only when edit mode is on * added: update grid on edited person cell; add translations * fixed: edit cell only if provider is bank Co-authored-by: Margarita <[email protected]> * Update Footer (#1092) * Migrate Footer styles * Update footer links * Remove unused translations from footer, fix footer links * Add title abobe footer link groups * Update footer links * Fix footer links translations * Fix translation typo * Style footer titles * Fix responsive styles for Footer * Remove Beta text from the logo (#1099) * Increase visible campaigns number (#1104) * Add SuperHosting partner in Footer (#1103) * Fix overlapping bug in Campaign Details page (#1106) * Add tag for successfull camapign (#1107) * update some gh actions Signed-off-by: Ivan Milchev <[email protected]> * My profile tabs in mobile to be scrollable (#1114) * Consistent date format in update birthday modal (#1115) * Consistent date format in update birthday modal * Generic formatting of date in birthday modal * Enable Terms and Conditions and GDPR validation on Register form (#1126) * Enable Terms and Conditions and GDPR validation on Register form * Add terms and gdpr in RegisterFormData * [Improvement] Upgrade dependencies including Next 13 and React 18 (#1125) * 1123 - bump up next and react versions * 1123 - move out next middlewares * 1123 - migrate to new next/image api and add a11y todos * 1123 - fix layout='fill' images and migrate to new next/link api * 1123 - fix banner image on details page and LinkMenuItems * 1123 - update next-auth version and fix Link with the new next/link api * 1123 - fix next-auth type and cleanup conosole.log * 1123 - remove and replace console.logs from DonationTables * 1123 - add swcMinify to the config * 1123 - update i18n dependency * 1123 - fix fill image on the one time donation page * 1123 - update typescript, fix typings and add ExternalLinkMenuItem component * 1123 - fix @react-pdf typings and other left out * 1123 - revert test:e2e command * 1123 - remove unecessary resolution * 1123 - update support page e2e tests to match behaviour * 1123 - fix expects on the homepage tests and move out next/script * 1123 - update auth to now protect admin * add batebobo as a contributor for code (#1127) * update README.md [skip ci] * update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * add valkirilov as a contributor for code, and doc (#1128) * update README.md [skip ci] * update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * add devkishor8007 as a contributor for code (#1130) * update README.md [skip ci] * update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * add stann1 as a contributor for code, doc, and 3 more (#1131) * update README.md [skip ci] * update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Typescript Downgrade and WhatsApp @mui/icons change (#1132) * 1123 - bump up next and react versions * 1123 - move out next middlewares * 1123 - migrate to new next/image api and add a11y todos * 1123 - fix layout='fill' images and migrate to new next/link api * 1123 - fix banner image on details page and LinkMenuItems * 1123 - update next-auth version and fix Link with the new next/link api * 1123 - fix next-auth type and cleanup conosole.log * 1123 - remove and replace console.logs from DonationTables * 1123 - add swcMinify to the config * 1123 - update i18n dependency * 1123 - fix fill image on the one time donation page * 1123 - update typescript, fix typings and add ExternalLinkMenuItem component * 1123 - fix @react-pdf typings and other left out * 1123 - revert test:e2e command * 1123 - remove unecessary resolution * 1123 - update support page e2e tests to match behaviour * 1123 - fix expects on the homepage tests and move out next/script * 1123 - update auth to now protect admin * change out WhatsAppOutlined for WhatsApp in `socialMedia.ts` * remove ts-expec-error from chat.tsx * return @ts-expect-error on the chat.tsx component * return typescript to 4.5.5 * update to typescript 4.8.3 * Fix visual issue with Menu items in the MainNav (#1121) * Fix visual issue with Menu items in the MainNav - increase the spacing between the Button and the opened dropdown with the Menu items so they don't interfere with the border of the "Donate" button in the MainNav References: #1016 * Refactoring of the GenericMenu component - chage the way we set the spacing between the `Button` and the `Menu` dropdown list to use `PaperProps` instead of wrapping it behind a `styled` component. It's simpler now. - rename the `GenericMenu` component to `GenericNavMenu` so it will distinguish its purpose way more clearly - fix the `id` attribute to be properly set via an input prop instead of using always the default wrong `menu-donation` for all items of this type * [Bug] You can click Next if you are both not logged and not anonymous (#1134) * 1133 - disable next button when not logged in * 1133 - fix anonymous submit value when mutating * 1133 - add option to be able to donate anonymous even if you are logged in * 1133 - remove console.logs * 1133 - add enum for auth step tabs * 1133 - change Tabs to strings * Modularize MUI imports and bump up MUI version (#1135) * Add expermental flag to modularize mui imports * Bump up mui versions and add modularizeImports experimental flag to the `next.config` * Fix Autocomplete import * 1109 (#1141) Added iban trimmed value on click copy button * 1113 Added border to button in login page (#1142) Removed unused variable, which causes warning * add AnzheloD as a contributor for code (#1143) * update README.md [skip ci] * update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * 1096 - setup playwright add tests for the first donation step * Remove env variables from the backend actoin * Revert yarn.lock to the origin/master file * 1096 - Update anonymous donation flow to match the new master changes * 1096 - return env secrets to the backend action * 1096 - change env variables down the list in the playwright.yml * 1096 - increase the timeout time for the wait on backend action * 1096 - change action api branch and add logging artifact * 1096 - remove unecessary api artifcat action values * 1096 - change api logs artifact path * Revert "1096 - change api logs artifact path" This reverts commit bba2bc7. * 1096 - remove backend env variables from actions * store api and frontend logs to a file for playwright tests Signed-off-by: Ivan Milchev <[email protected]> * set stripe secrets for api in playwright tests Signed-off-by: Ivan Milchev <[email protected]> * another try of setting env for api in playwright Signed-off-by: Ivan Milchev <[email protected]> * 1096 - remove the dependabot file * 1096 - remove change from LoginForm and add a comment to the logged in user test * try setting the env for playwright tests Signed-off-by: Ivan Milchev <[email protected]> * added: setting version of yarn to ensure v3.3 will be called * Fix string litteral * set secrets explicitly for playwright workflow Signed-off-by: Ivan Milchev <[email protected]> * set yarn version for playwright workflow in a separate step Signed-off-by: Ivan Milchev <[email protected]> Signed-off-by: Ivan Milchev <[email protected]> Co-authored-by: Ivan Milchev <[email protected]> Co-authored-by: Margarita <[email protected]> Co-authored-by: Margarita <[email protected]> Co-authored-by: Ani <[email protected]> Co-authored-by: Lachezar Marinov <[email protected]> Co-authored-by: Boyan Vushkov <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Valentin Kirilov <[email protected]> Co-authored-by: Anzhelo Dimitrov <[email protected]> Co-authored-by: quantum-grit <[email protected]> Co-authored-by: Ilko Kacharov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The anonymous donation felt like it is not working properly. It was unpredictable.
Now in order enable the button click next on the login step you have to either:
Screenshots:
Testing
Went through the donation flow in all 3 cases: