Removed the delete functionality from my campaigns tab #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoychev
approved these changes
Oct 25, 2022
ani-kalpachka
approved these changes
Oct 25, 2022
kachar
reviewed
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The change is required because the normal user shouldn't be able to delete their campaigns in my campaigns tab in the user's profile
I fixed the GridActions.tsx component in components/campaigns to accept one additional property via props - allowDelete, because this component is also used in podkrepi.bg/admin/campaigns and if the property is set to false the delete icon is not displayed and the opposite if the property is set to true. I also cleaned up the MyCampaignsTable component to not have additional unused code. I saw that there was Root property with styles, which was unused and i just deleted it, if this has some reason to be there just comment and i will fix it .