Fixed the disabled scrolling when openning all dropdown menus #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-kalpachka
approved these changes
Oct 8, 2022
ani-kalpachka
deleted the
1047-bug-scroll-bar-disabled-on-desktop-when-a-dropdown-menu-is-opened
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user can't scroll down if a dropdown menu is opened.I already fixed that in #1044 but then i wasn't having the backend installed.Now when i have it i noticed that the problem also appears when a user(PrivateMenu)/admin(AdminMenu) is logged in.Also it appeared when clicking on the user profile icon(PublicMenu) (obviously i didn't checked that).But now i fixed the issue in every dropdown menu.
Closing #1047
The bug was noticed in the MUI github repository
From the comments on the issue i found a solution on stackoverflow https://stackoverflow.com/questions/69065717/material-ui-menu-component-locks-body-scrollbar/71671897#71671897
Solved disabled scroll when a dropdown menu is opened
I solved the issue like on the Menu Component that is comming from MUI there is a property disableScrollLock and i set it to true in three other Dropdown Menu Components (Admin,Private,Public)