Disable Beta Popup Dialog #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Playwright tests are actually testing the pop up as well. Now that it is gone, they fail. Try to fix them. It should be as easy as removing the lines that actually interact with the popup. 👀 |
kachar
reviewed
Aug 23, 2022
kachar
reviewed
Aug 23, 2022
kachar
reviewed
Aug 23, 2022
| @@ -11,12 +11,8 @@ import { | |||
| FormControlLabel, | |||
| Typography, | |||
| } from '@mui/material' | |||
There was a problem hiding this comment.
Let's remove the component, we can always bring it back from git history
imilchev
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled Beta Popup Dialog:
The component is not deleted in case we need it back. So far its import is commented.
Removed the unused imports in the component.