[2/2] Backend service for campaign's related news #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplication of CampaignFile module and accomodated to work for the news
-Seed 5 drafts -Seed 5 published news
On the frontend side the campaign title is needed when visualizing the news for specific campaign. This change prevents unexpected behavior such as the news page crashing in case no news were found for the specific campaign, or user has visited the news page via invalid campaign slug
-Change the key to `campaignNews` to correctly represent the name of the relation -Take the latest two published articles for the campaign
…ched -Needed to accomodate the latest frontend changes for SingleArticlePage -Include article slug in listAdmin `:campaignSlug/list` endpoint
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
igoychev
requested changes
Jun 17, 2023
apps/api/src/domain/generated/campaignNews/dto/create-campaignNews.dto.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+6
to
+7
| const SEED_PUBLISHED_NEWS = 5 | ||
| const SEED_DRAFT_NEWS = 5 |
There was a problem hiding this comment.
cool for adding the seeds!
| @@ -0,0 +1,20 @@ | |||
| -- AlterEnum | |||
| ALTER TYPE "campaign_file_role" ADD VALUE 'gallery'; | |||
There was a problem hiding this comment.
nice! definitely needed for other improvements too!
It will be received by the auth header now
sashko9807
force-pushed
the
campaign-news-functionality
branch
from
87b2904 to
c7a7e64
Compare
github-actions
bot
removed
the
run tests
when importing external services, they need to be imported through their module
github-actions
bot
removed
the
run tests
As we import the PersonModule, there is no need for injecting PersonService anymore
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
igoychev
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary to #1446
Motivation and context
This PR contains the necessary backend changes to serve the campaign related news functionality
Testing
Steps to test
New endpoints
Environment
New environment variables:
NEW_ENV_VAR: env var detailsNew or updated dependencies:
dependency/namev1.0.0v2.0.0