Add Postgres adapter for socket communication #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
removed
the
run tests
|
Please provide context about why this is needed and what purpose does it serve |
imilchev
requested changes
Mar 5, 2023
https://docs.nestjs.com/websockets/adapter |
kachar
reviewed
Mar 11, 2023
Comment on lines
26
to
30
| CREATE TABLE IF NOT EXISTS socket_io_attachments ( | ||
| id bigserial UNIQUE, | ||
| created_at timestamptz DEFAULT NOW(), | ||
| payload bytea | ||
| ); |
There was a problem hiding this comment.
The tables normally should be created via schema.prisma instead of at runtime
There was a problem hiding this comment.
Good to know. I will change it, thanks!
added 3 commits
March 13, 2023 13:59
github-actions
bot
removed
the
run tests
github-actions
bot
removed
the
run tests
|
If i correctly understood the socket.io adapter docs, this is only needed in cases when we want to emit messages across multiple server instances, which does not seem to be the case for us, at least for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have more than one server, we need this adapter as a way to notify all the servers of a specific event, so all the clients get notified.
For example, we receive a valid payment on only one server, and we need a way to notify all the users who might be connected to the other server.