-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export data to excel #391
Export data to excel #391
Conversation
add methods supporting excel export add types
…ure/export-data-to-excel
❌ Not all tests have run for this PR. Please add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreyGoranov Everything looks smooth and nice!
The only thing that looks strange to me is the 15k rows diff by the added yarn.lock
file. Looks like it's been changed entirely. Can you check that please?
@kachar yes will do I had a merge conflict on it and probably I didn't resolve it right |
@AndreyGoranov You can delete the local file and run I hope you're using yarn 3 ( |
@AndreyGoranov I think this yarn update has messed up the versions of a couple of dependencies, for example, |
@kachar I think its ok now ? |
…reyGoranov/api into feature/export-data-to-excel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndreyGoranov Nice upgrade of the api!
It wasn't easy to make the tests and check green, but we've managed it. Thanks for the collaboration along the way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change requested:
The amounts in the exported file should be divided by 100 to contain the cents.
@AndreyGoranov Can you please create a PR with the update that @igoychev mentioned above? |
Issue: podkrepi-bg/frontend#700