Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data to excel #391

Merged
merged 13 commits into from
Dec 11, 2022

Conversation

AndreyGoranov
Copy link
Contributor

@AndreyGoranov AndreyGoranov commented Dec 9, 2022

Issue: podkrepi-bg/frontend#700

  • Add Export module.
  • Export service to be used around the app in different services that would require exporting.
  • There is an option to specify everything about the template in a single JSON or you could use a default setup with all columns from the data provided for exporting.
  • Add new dependency: https://github.com/exceljs/exceljs
  • Use types for the exportable data and add types for the template as well

Andrey added 3 commits December 8, 2022 19:22
add methods supporting excel export
add types
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

❌ Not all tests have run for this PR. Please add the run tests label to trigger them.

@AndreyGoranov AndreyGoranov changed the title Feature/export data to excel Export data to excel Dec 9, 2022
Copy link
Member

@kachar kachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreyGoranov Everything looks smooth and nice!

The only thing that looks strange to me is the 15k rows diff by the added yarn.lock file. Looks like it's been changed entirely. Can you check that please?

@AndreyGoranov
Copy link
Contributor Author

@kachar yes will do I had a merge conflict on it and probably I didn't resolve it right

@kachar
Copy link
Member

kachar commented Dec 9, 2022

@AndreyGoranov You can delete the local file and run yarn to regenerate it.

I hope you're using yarn 3 (yarn set version berry)

@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@kachar
Copy link
Member

kachar commented Dec 9, 2022

@AndreyGoranov I think this yarn update has messed up the versions of a couple of dependencies, for example, @prisma/client has been updated from 4.3.1 to 4.7.1 because it's defined with ^ prefix in package.json

image

@AndreyGoranov
Copy link
Contributor Author

@kachar I think its ok now ?

@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 9, 2022
@AndreyGoranov AndreyGoranov requested a review from kachar December 10, 2022 16:37
@kachar kachar added the run tests Allows running the tests workflows for forked repos label Dec 10, 2022
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Dec 10, 2022
Copy link
Member

@kachar kachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreyGoranov Nice upgrade of the api!

It wasn't easy to make the tests and check green, but we've managed it. Thanks for the collaboration along the way

@kachar kachar merged commit dbc3a45 into podkrepi-bg:master Dec 11, 2022
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change requested:
The amounts in the exported file should be divided by 100 to contain the cents.

@kachar
Copy link
Member

kachar commented Dec 12, 2022

@AndreyGoranov Can you please create a PR with the update that @igoychev mentioned above?

@AndreyGoranov
Copy link
Contributor Author

AndreyGoranov commented Dec 12, 2022

@kachar #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants