Feature/update donation person #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success176 tests passing in 64 suites. Report generated by 🧪jest coverage report action from 5ddcba7 |
igoychev
requested changes
Oct 28, 2022
Comment on lines
+333
to
+339
| const targetDonor = await this.prisma.person.findFirst({ | ||
| where: { id: updatePaymentDto.targetPersonId }, | ||
| }) | ||
| if (!targetDonor) { | ||
| throw new NotFoundException( | ||
| `Update failed. No person found with ID: ${updatePaymentDto.targetPersonId}`, | ||
| ) |
There was a problem hiding this comment.
May be we can skip checking for if the targetPersonId exists, because it will be checked automatically by the ForeignKey when updating the donation.
There was a problem hiding this comment.
true, but then the user will get a system unhandled exception, this way it is much more user friendly
There was a problem hiding this comment.
What do you think about handling the exception. Just found that Prisma has an error code for this case P2003 and the exception docs show how to handle it: https://www.prisma.io/docs/concepts/components/prisma-client/handling-exceptions-and-errors
igoychev
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the backend part for: podkrepi-bg/frontend#958