Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using native sendfile from OS for HttpServer #4351

Merged
merged 11 commits into from
Sep 1, 2024
Merged

Using native sendfile from OS for HttpServer #4351

merged 11 commits into from
Sep 1, 2024

Conversation

bas524
Copy link
Contributor

@bas524 bas524 commented Dec 16, 2023 •
edited
Loading

This PR is motivated by #3368 and continuation of #4007

If OS has native implementation of sendfile function then it will be used (only for cmake projects).
Other projects (make and vcxporj) you can uncomment define POCO_HAVE_SENDFILE in Poco/Config.h

Note for emscripten sendfile will throw NotImplemented exception, because emscripten-core/emscripten#16234

Simple proof that this optimization is useful

Test without optimization

testFile:

OK (1 tests)

./Net-testrunner testFile  0.04s user 0.01s system 15% cpu 0.297 total

Test with optimization

testFile:

OK (1 tests)

./Net-testrunner testFile  0.03s user 0.01s system 5% cpu 0.842 total

15% vs 5%

@bas524
add possibility to use native sendFile from OS for HttpServerResponse
f6226ff 
add option POCO_USE_SENDFILE_FOR_HTTPSERVER, default - OFF
add test for HttpServer - testFile
add define fro Config.h POCO_USE_SENDFILE_FOR_HTTPSERVER
@bas524
my fail, be carefull with macro and brackets
09ddc0d
teksturi
teksturi reviewed Dec 16, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@bas524
replace option POCO_USE_SENDFILE_FOR_HTTPSERVER with compiletime
21c49c5 
detected macro POCO_HAVE_SENDFILE
replace types for sendFile with platform depended
wrap possibility of using sendFile with macro, if sendFile doesn't exist
in OS, then all methods don't exist
teksturi
teksturi reviewed Dec 17, 2023
View reviewed changes
Net/src/SocketImpl.cpp Outdated Show resolved Hide resolved
@bas524
Copy link
Contributor Author

bas524 commented Jan 16, 2024

Hi, @obiltschnig !
May be You have any remarks?

@matejk matejk deleted the branch pocoproject:main April 15, 2024 11:20
@matejk matejk closed this Apr 15, 2024
@matejk matejk reopened this Apr 22, 2024
@matejk matejk changed the base branch from devel to main April 22, 2024 06:57
@matejk
Copy link
Contributor

matejk commented Jul 29, 2024 •
edited
Loading

@bas524 , can you rebase on latest code on main branch, please?

@bas524
Copy link
Contributor Author

bas524 commented Jul 31, 2024

@bas524 , can you rebase on latest code on main branch, please?

Hi, ok. I'll do it this week

@matejk matejk removed the pending label Aug 1, 2024
aleks-f
aleks-f requested changes Aug 2, 2024
View reviewed changes
Net/include/Poco/Net/SocketImpl.h Outdated Show resolved Hide resolved
@matejk matejk merged commit 710c2a4 into pocoproject:main Sep 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teksturi teksturi teksturi left review comments

@obiltschnig obiltschnig obiltschnig left review comments

@aleks-f aleks-f aleks-f requested changes

@matejk matejk matejk approved these changes

Assignees
No one assigned
Labels
enhancement performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bas524 @matejk @obiltschnig @aleks-f @teksturi