-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge DNSSD into main Poco #3933
Conversation
…be work correctly. (see pocoproject#1)
Add cmake build way.
Minor change.
Removed ambiguous sentence.
Please rerun CI, I want to ensure Linux cmake pipeline work correctly. if you want to pass macos pipelines, I suggest install bonjour on macos image (I do not know how to do it?), and for Windows Server pipeline you must install bonjour-sdk I can disable DNSSD in all failed pipelines if you want @aleks-f thanks for review this PR |
I disable DNSSD in all failed pipelines. Please rerun CI, I want to ensure work correctly. thanks |
@aleks-f please rerun CI, I hope all of pipeline works correctly thanks |
@aleks-f Did you have any time to review it? thanks |
@aleks-f Did you can review this PR? thanks |
@soroshsabz I'm not sure what the status is with the CI builds, they just stopped triggering |
@aleks-f I think you have to reactivate CI manually |
@soroshsabz I can't find CI anywhere for this PR |
@aleks-f As you can see, we have some conflict during this time, I resolve this, So you can merge it thanks |
@aleks-f for example as you can see in #3919 some PR does not have CI status, if you approve this PR, CI started, as you can see in below image and see the Learn More |
@aleks-f as you can see all checks passed, so did you can merge this PR? |
@aleks-f Any update? as you can see all checks has been passed |
@aleks-f I resolves all your conversations so please review again |
@aleks-f So please merge it :) |
@matejk put this on TODO list, not urgent for 1.13 milestone (won't go into released code for now anyway); probably best to create another PR, because this one does not trigger all CI for some reason |
ITNOA
Merge DNSSD into main Poco project
fixes #2208