Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DNSSD into main Poco #3933

Closed
wants to merge 25 commits into from
Closed

Conversation

soroshsabz
Copy link
Contributor

ITNOA

Merge DNSSD into main Poco project

fixes #2208

@soroshsabz
Copy link
Contributor Author

soroshsabz commented Jan 27, 2023

Please rerun CI, I want to ensure Linux cmake pipeline work correctly.

if you want to pass macos pipelines, I suggest install bonjour on macos image (I do not know how to do it?), and for Windows Server pipeline you must install bonjour-sdk

I can disable DNSSD in all failed pipelines if you want

@aleks-f thanks for review this PR

@soroshsabz
Copy link
Contributor Author

I disable DNSSD in all failed pipelines.

Please rerun CI, I want to ensure work correctly.

thanks

@soroshsabz
Copy link
Contributor Author

@aleks-f please rerun CI, I hope all of pipeline works correctly

thanks

@soroshsabz
Copy link
Contributor Author

@aleks-f Did you have any time to review it?

thanks

@soroshsabz
Copy link
Contributor Author

@aleks-f Did you can review this PR?

thanks

@aleks-f
Copy link
Member

aleks-f commented Mar 17, 2023

@soroshsabz I'm not sure what the status is with the CI builds, they just stopped triggering

@soroshsabz
Copy link
Contributor Author

@aleks-f I think you have to reactivate CI manually

@aleks-f
Copy link
Member

aleks-f commented Mar 18, 2023

@soroshsabz I can't find CI anywhere for this PR

@soroshsabz
Copy link
Contributor Author

@aleks-f As you can see, we have some conflict during this time, I resolve this, So you can merge it

thanks

@soroshsabz
Copy link
Contributor Author

@aleks-f for example as you can see in #3919 some PR does not have CI status, if you approve this PR, CI started, as you can see in below image and see the Learn More

image

@soroshsabz
Copy link
Contributor Author

@aleks-f as you can see all checks passed, so did you can merge this PR?

@soroshsabz
Copy link
Contributor Author

@aleks-f Any update? as you can see all checks has been passed

CMakeLists.txt Outdated Show resolved Hide resolved
DNSSD/.gitignore Outdated Show resolved Hide resolved
@soroshsabz
Copy link
Contributor Author

@aleks-f I resolves all your conversations

so please review again

@soroshsabz
Copy link
Contributor Author

@aleks-f So please merge it :)

@aleks-f
Copy link
Member

aleks-f commented Dec 4, 2023

@matejk put this on TODO list, not urgent for 1.13 milestone (won't go into released code for now anyway); probably best to create another PR, because this one does not trigger all CI for some reason

@soroshsabz
Copy link
Contributor Author

@aleks-f @matejk I can create another PR for this branch

but I have one question, as I can see all checks have passed, what error do you see?

@soroshsabz soroshsabz closed this Dec 5, 2023
@soroshsabz
Copy link
Contributor Author

@aleks-f @matejk I create another PR for this in #4323

I am happy to merge that PR

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Poco DNSSD to Poco
4 participants