MinGW support #2360

ark0f · 2018-06-05T13:00:10Z

All components work excluding:

ApacheConnector (MSYS2 required)
MySQL (MariaDB connector doesn't support MinGW)

Message compiler automatically disable in MinGW if it is not exists.
Add wrapper for wmain() that will be used in Application and ServerApplication. It can be disabled by POCO_NO_WMAIN_WRAPPER definition.
Change logic of NetworkInitialzer in Util.h.

Fix several tests.

Fix missing argument name in functions "setEscapeUnicode" in JSON package.

TODO list: * Fix tests compilation (undefined reference to CppUnit::...) * Fix SQLs compilation (No rule to make target '${LIBNAME}.dll.a', needed by '${LIBNAME}.dll'. Stop.) * Fix crypto executables compilation * Test static compilation * Test MSVC compilation * Add unicode support See pocoproject#2356

Also fix PDF test runner. TODO list: * Fix tests compilation (undefined reference to CppUnit::...) * Add unicode support * Resolve what to do with message compiler See pocoproject#2356

…ral implementations. Add "POCO_NO_MINGW_UNICODE" for "wmain". TODO list: * Check PostgreSQL and MySQL * Resolve what to do with message compiler See pocoproject#2356

See pocoproject#2356

aleks-f · 2018-06-05T15:31:32Z

Crypto/samples/genrsakey/CMakeLists.txt

@@ -1,2 +1,4 @@
 add_executable(genrsakey src/genrsakey.cpp)
 target_link_libraries(genrsakey PUBLIC Poco::Crypto Poco::Util Poco::XML)
+
+POCO_ENABLE_EXE_WMAIN(genrsakey)


@Bjoe can you please confirm this is the right thing to do

See my review comment...

aleks-f · 2018-06-05T15:32:57Z

Foundation/src/Error.cpp

 			UnicodeConverter::toUTF8(lpMsgBuf, errMsg);
-	#endif
+		}


aleks-f · 2018-06-05T15:38:59Z

Foundation/testsuite/src/FileTest.cpp

@@ -20,6 +20,9 @@
 #include <set>


+#define MAX_PATH 260


please shield this with #ifndef MAX_PATH

aleks-f · 2018-06-05T15:39:26Z

Net/CMakeLists.txt

    else()    
-        target_link_libraries(Net PUBLIC "ws2_32.lib")
+        target_link_libraries(Net PUBLIC "ws2_32")


Well I don't know yet if this will work with microsoft compile. But ws2_32 is better then ws2_32.lib .... I would like to investigate if cmake support .lib suffix for microsoft compiler...

aleks-f · 2018-06-05T15:41:51Z

NetSSL_Win/src/Context.cpp

+					NULL,
+	#else
+					0,
+	#endif


please just use 0 here, but why is NULL not good here and is in the last argument?

Because function required number in MinGW

aleks-f · 2018-06-05T15:42:01Z

NetSSL_Win/src/Context.cpp

+			NULL,
+	#else
+			0,
+	#endif


same as above

See pocoproject#2360

ark0f · 2018-06-05T18:19:33Z

Please, cancel build develop-3561 at AppVeyor as I pushed new commit.

Bjoe

Please read https://github.com/pocoproject/poco/wiki/CMake-contribution-rules

Bjoe · 2018-06-05T19:49:18Z

CMakeLists.txt

@@ -81,6 +85,10 @@ else()
    option(BUILD_SHARED_LIBS "Build shared libraries" ON)
 endif()

+if(BUILD_SHARED_LIBS AND MINGW)
+    add_definitions(-D_DLL)


Don't use "add_definitons". Use target_compile_definitons ... See also CMake-contribution-rules

Define _DDL use almost all packages and dependencies. Do you offer to define it for every target? Or you offer define as PUBLIC?

You should ask your self, if it is mandatory to set also _DLL into your project they use the compiled poco library ? Mostly I checked in the code if this preprocessor definiton is in the header file .... if not, then it can be PRIVATE (it is only need to compile the poco librarie) ... if it is in the header file, then you should investigate is this header file published with the compiled library ... if yes then it is mostly mandatory that you added this as PUBLIC because it is needed to use the compiled poco library into your project. You should not added these to every target. Added with target_compile_definition with PUBLIC there where it is used and this definiton will be provided to the other targets they use this target. For example for me we should add this on the Poco::Foundation target. All of the other targets depends on Poco::Foundation and get this definiton ...See also target_compile_definitions I found that _DLL is used in Crypto.h, CppUnit.h, Foundation,h, NetSSL.h, pngconf.h .... I see also we have POCO_DLL ... hmmm is this the same?

Bjoe · 2018-06-05T19:54:11Z

PDF/CMakeLists.txt

@@ -134,6 +134,10 @@ target_include_directories(PDF
    PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/src
    )

+if(MINGW)
+    add_definitions(-DHPDF_DLL_MAKE_CDECL)


Don't use add_definitons ... use target_compile_definitons. See also CMake-contribution-rules

Bjoe · 2018-06-05T20:28:51Z

cmake/PocoMacros.cmake

+
+macro(POCO_ENABLE_EXE_WMAIN target_name)
+    if(MINGW)
+        set_target_properties("${target_name}" PROPERTIES LINK_FLAGS "-municode")


-municode is needed to compile unicode applications. Should be activated when Uniicode support is enabled in poco or?
I found also this

Help! I get an error: unrecognized command line option "-municode"!

in MinGW wikiUnicode applications

Normaly CMake takes care that it works on all compilers and platforms. See also CMake rulse:

Don't make any assumption about the platform or compiler!

I would like to investigate if cmake has any support for such compile flag.

Try to compile application with wmain using MinGW. You'll get undefined reference to WinMain, if you don't add this option. Also see https://stackoverflow.com/a/11706847.
And quote from MinGW wiki:

While it is not necessary to define _UNICODE or UNICODE to compile the above code, -municode is needed for linking because it uses wmain() instead of the traditional main().

But wmain is needed when you will have unicode support or? For me it looks like this depends on POCO_ENBALE_WSTRING .... but I'm still investigating...

ark0f · 2018-06-05T21:03:17Z

CMakeLists.txt

@@ -2,6 +2,10 @@ cmake_minimum_required(VERSION 3.2.0)

 project(Poco)

+if(WINCE AND MINGW)
+    message(FATAL_ERROR "MinGW does not support WinCE")


I think I should delete this. CMake will cope with this.

I think also we should remove this.... mingw will not work at all on wince ...

See pocoproject#2360

Bjoe · 2018-06-06T10:03:26Z

CMakeLists.txt

@@ -2,6 +2,10 @@ cmake_minimum_required(VERSION 3.2.0)

 project(Poco)

+if(WINCE AND MINGW)
+    message(FATAL_ERROR "MinGW does not support WinCE")


I think also we should remove this.... mingw will not work at all on wince ...

Bjoe · 2018-06-06T10:53:03Z

CMakeLists.txt

@@ -81,6 +85,10 @@ else()
    option(BUILD_SHARED_LIBS "Build shared libraries" ON)
 endif()

+if(BUILD_SHARED_LIBS AND MINGW)
+    add_definitions(-D_DLL)


You should ask your self, if it is mandatory to set also _DLL into your project they use the compiled poco library ? Mostly I checked in the code if this preprocessor definiton is in the header file .... if not, then it can be PRIVATE (it is only need to compile the poco librarie) ... if it is in the header file, then you should investigate is this header file published with the compiled library ... if yes then it is mostly mandatory that you added this as PUBLIC because it is needed to use the compiled poco library into your project. You should not added these to every target. Added with target_compile_definition with PUBLIC there where it is used and this definiton will be provided to the other targets they use this target. For example for me we should add this on the Poco::Foundation target. All of the other targets depends on Poco::Foundation and get this definiton ...See also target_compile_definitions I found that _DLL is used in Crypto.h, CppUnit.h, Foundation,h, NetSSL.h, pngconf.h .... I see also we have POCO_DLL ... hmmm is this the same?

Bjoe · 2018-06-06T10:55:15Z

Net/src/PollSet.cpp

@@ -44,7 +44,6 @@
 namespace Poco {
 namespace Net {

-


Please read contribution documentation about code formatting

Bjoe · 2018-06-06T10:55:31Z

MongoDB/include/Poco/MongoDB/MongoDB.h

@@ -31,8 +31,6 @@
 // MongoDB_API functions as being imported from a DLL, whereas this DLL sees symbols
 // defined with this macro as being exported.
 //
-
-


Please read contribution documentation about code formatting

Bjoe · 2018-06-06T10:57:20Z

SQL/include/Poco/SQL/SQL.h

@@ -31,7 +31,6 @@
 // Poco_SQL_API functions as being imported from a DLL, whereas this DLL sees symbols
 // defined with this macro as being exported.
 //
-


Please read contribution documentation about code formatting :-)

Bjoe · 2018-06-06T11:00:15Z

cmake/PocoMacros.cmake

+
+macro(POCO_ENABLE_EXE_WMAIN target_name)
+    if(MINGW)
+        set_target_properties("${target_name}" PROPERTIES LINK_FLAGS "-municode")


But wmain is needed when you will have unicode support or? For me it looks like this depends on POCO_ENBALE_WSTRING .... but I'm still investigating...

Bjoe · 2018-06-06T11:05:04Z

Util/include/Poco/Util/ServerApplication.h

@@ -232,7 +232,7 @@ class Util_API ServerApplication: public Application
 //
 // Macro to implement main()
 //
-#if defined(_WIN32) && !defined(__MINGW32__)
+#if defined(_WIN32) && !defined(POCO_NO_MINGW_UNICODE)


No unicode ? I was expected you should have wmain for unicode support?

Option -municode affect to WinAPI too. For example InetPton. It is define to InetPtonA or to InetPtonW. If option -municode set, InetPton will be InetPtonW. If not, InetPton will be InetPtonA.
What does mean A or W:
https://msdn.microsoft.com/en-us/library/windows/desktop/dd374089(v=vs.85).aspx

As stated in the URL

A Windows code page version with the letter "A" used to indicate "ANSI" A Unicode version with the letter "W" used to indicate "wide"

… now. See pocoproject#2360

See pocoproject#2360

…y. Add var to disable MinGW wmain wrapper.

…kage.

aleks-f · 2018-06-16T00:02:24Z

I'm ok with changes, @zosrothko there's appveyor NetSSL test failure but I don't think it is related to this pull, can you check?

Bjoe

Please fix some finding in cmake.

Bjoe · 2018-06-18T12:05:28Z

Crypto/testsuite/src/CryptoTestSuite.cpp

@@ -10,7 +10,7 @@

 #include "Poco/Platform.h"
 // see https://github.com/openssl/openssl/blob/master/doc/man3/OPENSSL_Applink.pod
-#if defined(POCO_OS_FAMILY_WINDOWS)
+#if defined(_MSC_VER)


Sometimes I see, we use POCO_OS_FAMILY_WINDOWS and sometimes we use _MSC_VER .... May I ask what is the difference?

OpenSSL for MinGW has no applink.c.

Bjoe · 2018-06-18T12:09:27Z

Net/CMakeLists.txt

+    endif()
+
+    if(MINGW) # Needed by WinAPI in MinGW
+        string(REGEX MATCH "^[0-9]+\\.[0-9]+" WIN_VERSION ${CMAKE_SYSTEM_VERSION})


In cmake it is possible to verify version numbers with VERSION_LESS etc. See https://cmake.org/cmake/help/latest/command/if.html?highlight=version_less

It doesn't verify version, it calculate it from version like 6.0.141241 to 0x0600.

Take first two numbers 6 and 0, so we get 6.0

It take major version, so we get 6

It take minor version, so we get 0

Transform these two numbers to version like WinAPI. 256 * 6 + 0 = 1536 or 0x0600
If windows version differ, WinAPI version will be different too.

Bjoe

ok

Bjoe · 2018-06-19T14:37:50Z

Net/CMakeLists.txt

+    endif()
+
+    if(MINGW) # Needed by WinAPI in MinGW
+        string(REGEX MATCH "^[0-9]+\\.[0-9]+" WIN_VERSION ${CMAKE_SYSTEM_VERSION})


Bjoe · 2018-06-19T14:38:02Z

MongoDB/include/Poco/MongoDB/MongoDB.h

@@ -31,8 +31,6 @@
 // MongoDB_API functions as being imported from a DLL, whereas this DLL sees symbols
 // defined with this macro as being exported.
 //
-
-


Bjoe · 2018-06-19T14:38:11Z

Crypto/testsuite/src/CryptoTestSuite.cpp

@@ -10,7 +10,7 @@

 #include "Poco/Platform.h"
 // see https://github.com/openssl/openssl/blob/master/doc/man3/OPENSSL_Applink.pod
-#if defined(POCO_OS_FAMILY_WINDOWS)
+#if defined(_MSC_VER)


Bjoe · 2018-06-19T14:38:33Z

SQL/include/Poco/SQL/SQL.h

@@ -31,7 +31,6 @@
 // Poco_SQL_API functions as being imported from a DLL, whereas this DLL sees symbols
 // defined with this macro as being exported.
 //
-


filimonov · 2018-07-21T12:29:45Z

MySQL (MariaDB connector doesn't support MinGW)

Did you try that?

pacman -S --needed mingw-w64-x86_64-openssl mingw-w64-x86_64-libmariadbclient

And after that apply patch from https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-poco/012-find-mysql.patch

Also you can review other patches from https://github.com/Alexpux/MINGW-packages/tree/master/mingw-w64-poco

ark0f · 2018-07-31T17:09:23Z

But how use libmariadbclient outside of MSYS2?

filimonov · 2018-08-01T12:40:44Z

Static linking? And as you see from prefix mingw-w64-x86_64 it is mingw64 native, not msys2 dependant.

BTW: i've tryed to build latest develop of poco on mingw (on windows 7). It build ok, but lot of tests fail. Do tests pass on your build?

filimonov · 2018-08-01T12:48:32Z

Here are the package file with patches needed to support mariadbcliect on mingw platform https://github.com/Alexpux/MINGW-packages/tree/bdc31c969f802816604254c938c524d3a8283530/mingw-w64-libmariadbclient

ark0f · 2018-08-01T13:12:27Z

About tests. As I understand, it are require run some services, eg. Redis, MySql, etc. Also some packages are not in release yet.

ark0f · 2018-08-01T13:17:50Z

And about patches. I'll try to use them myself on mariadb-connector-c.

ark0f added 5 commits June 3, 2018 01:17

Code rearrange.

a957ef0

Also fix PDF test runner. TODO list: * Fix tests compilation (undefined reference to CppUnit::...) * Add unicode support * Resolve what to do with message compiler See pocoproject#2356

Normal "_DLL" definition for MinGW. Add missing "Crypto_API" for seve…

cf60c8d

…ral implementations. Add "POCO_NO_MINGW_UNICODE" for "wmain". TODO list: * Check PostgreSQL and MySQL * Resolve what to do with message compiler See pocoproject#2356

Test PostgreSQL. Fix message compiler problem.

9879965

See pocoproject#2356

Resolve merge conflict

7e70fa8

aleks-f requested changes Jun 5, 2018

View reviewed changes

aleks-f requested a review from Bjoe June 5, 2018 15:44

Perform requested changes. Add WinCE check.

b15db46

See pocoproject#2360

Bjoe requested changes Jun 5, 2018

View reviewed changes

ark0f commented Jun 5, 2018

View reviewed changes

Perform requested changes pocoproject#2. Delete WinCE check.

e2534d4

See pocoproject#2360

Bjoe requested changes Jun 6, 2018

View reviewed changes

ark0f and others added 11 commits June 7, 2018 12:46

Perform requested changes pocoproject#3. Net initializer should works…

98492f5

… now. See pocoproject#2360

Fix invalid indent.

dc6602e

See pocoproject#2360

Correct definition of POCO_NO_MINGW_UNICODE.

a885d0b

See pocoproject#2360

Remove macro and set global linke flags for testing purpose

e539c07

Add -municode for mingw where wmain is used

711696f

Delete "POCO_ENABLE_EXE_WMAIN". Add PollSet support.

2ea9bf4

See pocoproject#2360

Merge remote-tracking branch 'bjoe/mingw-support' into mingw-support

d99bd11

Restore WinCE linker flags. Set _WIN32_WINNT in PollSet.cpp separatel…

ff9fd43

…y. Add var to disable MinGW wmain wrapper.

Fix compilation.

edd44d3

Merge remote-tracking branch 'upstream/develop' into mingw-support

32d40da

Fix missing argument name in functions "setEscapeUnicode" in JSON pac…

e781565

…kage.

aleks-f approved these changes Jun 16, 2018

View reviewed changes

aleks-f requested a review from zosrothko June 16, 2018 00:02

zosrothko approved these changes Jun 16, 2018

View reviewed changes

Bjoe requested changes Jun 18, 2018

View reviewed changes

Bjoe approved these changes Jun 19, 2018

View reviewed changes

aleks-f merged commit 0379a1e into pocoproject:develop Jun 19, 2018

ark0f mentioned this pull request Aug 1, 2018

MySQL support for MinGW #2416

Merged

Krzmbrzl mentioned this pull request Aug 23, 2020

Fix Poco only building "Basic Edition" mxe/mxe#2553

Open

+              					NULL,
+              	#else
+,
+              	#endif

MinGW support #2360

MinGW support #2360

Conversation

ark0f commented Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f commented Jun 5, 2018

Bjoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleks-f commented Jun 16, 2018

Bjoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ark0f Jun 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bjoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

filimonov commented Jul 21, 2018

ark0f commented Jul 31, 2018

filimonov commented Aug 1, 2018 • edited Loading

filimonov commented Aug 1, 2018

ark0f commented Aug 1, 2018 • edited Loading

ark0f commented Aug 1, 2018

ark0f commented Jun 5, 2018 •

edited

Loading

ark0f Jun 5, 2018 •

edited

Loading

ark0f Jun 5, 2018 •

edited

Loading

ark0f Jun 5, 2018 •

edited

Loading

ark0f Jun 6, 2018 •

edited

Loading

ark0f Jun 18, 2018 •

edited

Loading

ark0f Jun 18, 2018 •

edited

Loading

filimonov commented Aug 1, 2018 •

edited

Loading

ark0f commented Aug 1, 2018 •

edited

Loading