Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poco::FileInputStream broken in 1.12.5 and 1.11.8. #4241

Closed
jbulow opened this issue Oct 31, 2023 · 1 comment
Closed

Poco::FileInputStream broken in 1.12.5 and 1.11.8. #4241

jbulow opened this issue Oct 31, 2023 · 1 comment
Assignees
@obiltschnig
Labels
bug fixed
Milestone
Release 1.13.0

Comments

@jbulow
Copy link

jbulow commented Oct 31, 2023

See 4244c32#r131403165
obiltschnig added a commit that referenced this issue Nov 2, 2023
@obiltschnig
#4241: Poco::FileInputStream broken in 1.12.5 and 1.11.8.
fe5742f
obiltschnig added a commit that referenced this issue Nov 2, 2023
@obiltschnig
#4241: Poco::FileInputStream broken in 1.12.5 and 1.11.8
c51a567
@obiltschnig obiltschnig self-assigned this Nov 2, 2023
@obiltschnig obiltschnig added the bug label Nov 2, 2023
@obiltschnig obiltschnig added this to the Release 1.13.0 milestone Nov 2, 2023
@obiltschnig
Copy link
Member

obiltschnig commented Nov 2, 2023 •
edited by aleks-f
Loading

This will be properly fixed in 1.13.

The main issue is that the original implementation with _defaultMode is broken conceptually.
Poco::FileInputStream, Poco::FileOutputStream and Poco::FileStream should have their own
open() methods with appropriate defaults.

There will be patch releases 1.11.8p1 and 1.12.5p1 with interim fixes to maintain binary compatibility.

obiltschnig added a commit that referenced this issue Nov 2, 2023
@obiltschnig
#4241: Poco::FileInputStream broken in 1.12.5 and 1.11.8.
743da56
aleks-f pushed a commit that referenced this issue Nov 23, 2023
@obiltschnig @aleks-f
#4241: Poco::FileInputStream broken in 1.12.5 and 1.11.8.
6464769
aleks-f pushed a commit that referenced this issue Nov 27, 2023
@obiltschnig @aleks-f
#4241: Poco::FileInputStream broken in 1.12.5 and 1.11.8.
6f10991
@aleks-f aleks-f closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obiltschnig obiltschnig

Labels
bug fixed
Projects
None yet
Milestone
Release 1.13.0
Development

No branches or pull requests
3 participants
@jbulow @obiltschnig @aleks-f