cross-platform improvements #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,8 +2,12 @@ | |||
|
|
|||
| #if TARGET_OS_IPHONE | |||
| # import <UIKit/UIKit.h> | |||
| # define SVGUI(kls) UI##kls | |||
| # define View UIView | |||
There was a problem hiding this comment.
If we want to do it this way, @compatibility_alias is more appropriate. Also, we need to use our prefix, we'd be very likely to conflict with a host project otherwise.
There was a problem hiding this comment.
Are you ok with PSVG as a prefix?
There was a problem hiding this comment.
added the PSVG prefix as well the @compatibility_alias directive: 4fa4e6c
barakwei
pushed a commit
to Lightricks/PocketSVG
that referenced
this pull request
Sep 19, 2019
Added support for seperate dimensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGImageView_iOS.h,SVGImageView_Mac.handSVGImageView.hare doing what should be the job of just one file, so i merged them intoSVGImageView.hSVGUI(kls) UI##klsis clever, but is really not very readable. I changed it to a more verbose list of#defines(inspired by Nuke, as it'll be easier for users to understand what they are.