Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 fixes #48

Merged
merged 38 commits into from
Jul 18, 2016
Merged

V2 fixes #48

merged 38 commits into from
Jul 18, 2016

Conversation

arielelkin
Copy link
Collaborator

  • solves merge conflicts with master (mainly due to Demo projects conflicts. Demo project superseded by SVGExample
  • update Podspec so that Cocoapods builds the framework
  • CONTRIBS should be merged with what was on @fjolnir's branch

iamdoron and others added 30 commits December 2, 2014 21:36
add OS X deployment target to podspec
…cientific notation no longer borks parsing
Adds support for:
Q,q = Quadratic Bézier
T,t = Smooth quadratic Bézier
- Replace check if index == 0 and while statement into
`doesValenceMatch` method that produces more descriptive logging when
the parameters are insufficient
- Compute `[token command] == ` once per append command.
- Prevent Q and S control points from mixing
- Q and S use last point drawn as control if the previous command did
not produce a control point of that type.
- Move to point was producing a line after it moved to that point
- L style commands should have 2 parameters
- Fix logging on unichar
Support Quadratic Bézier paths
Bug fix for NSBezierPath. Wrong method signature :)
Preprocessor condition added so we can use the same file for building
and IB without modification.
dynamic Interface Builder compatibility
As per w3.org specs, you can ommit command character for repeated path instructions.
Example 1: C command followed by 12 numbers means two repeated C commands.
Example 2: M or m command followed by 2 or more pairs of numbers is a shortcut for LineTo
For more information see: https://www.w3.org/TR/SVG/paths.html#PathData

Changes:
- Support for multiple coordinate pairs after M/m command
- Support for multiple coordinate pairs to the L/l/H/h/V/v
- Support for multiple coordinate pairs to the S/s/C/c
- Support for multiple coordinate pairs to the Q/q/T/t
Added repeat instruction support
@arielelkin arielelkin mentioned this pull request Jun 6, 2016
5 tasks
Ariel Elkin and others added 2 commits June 6, 2016 13:01
It was unused from what I could tell.
@fjolnir
Copy link
Member

fjolnir commented Jul 18, 2016

lgtm

@fjolnir fjolnir merged commit 92747b7 into v2 Jul 18, 2016
@arielelkin arielelkin deleted the v2-fixes branch August 23, 2016 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants