Improve OSX compatibility

[mcianni]

I fixed a couple syntax errors encountered when building for OSX.

[arielelkin]

Hey there,

Thanks for the pull request! It's looking good, but building for OS X fails as there's a problem on line 12 of PocketSVG.h: 'UIKit/UIkit.h' file not found

I don't understand why, as the ifdefs are working fine on the .m file. I tried adding #include "TargetConditionals.h" to the top of the file but still get the same problem... Any ideas?

Ariel

[mindbrix]

Hi Ariel. This works for me:

#if TARGET_OS_IPHONE

#import <UIKit/UIKit.h>

#else

#import <Cocoa/Cocoa.h>

#endif

[mcianni]

Good catch mindbrix, when building for osx, TARGET_OS_IPHONE is defined, but as 0.

My last commit fixes it throughout the project.

I also saw that error, but assuming it was a discrepancy between our environments I just #undef'd TARGET_OS_IPHONE in my .pch

Mike

[arielelkin]

Hey Mike (and Nigel),

Thanks for your contribution. I've now merged your pull request.

I would now like to add an example Xcode project for OS X, I'm working on it on the project's develop branch.

As you might see, things are working fine except for the CAShapeLayer's rendering upside down (uncomment line 290 of PocketSVG.m on the develop branch). I'm trying to find a way of doing this without calling CGContextTranslateCTM...

Let me know if you have any ideas..

Ariel

[mindbrix]

Hi Ariel. This translates from UIKit to Quartz coordinate spaces, vertically inverting the coordinates. It might work for SVGKit on OS X too.

Nigel.

CGAffineTransform uiKitCTM( CGRect viewBounds )
{
return CGAffineTransformConcat( CGAffineTransformMakeScale( 1.0f, -1.0f ), CGAffineTransformMakeTranslation( 0.0f, viewBounds.size.height ));
};

[mcianni]

Ariel,

If you move the drawing code to a subclass of NSView, you can override

- (BOOL)isFlipped
{
    return YES;
}

to flip the vertical plane. (I'm sure this just uses Nigel's solution.)

Mike

[arielelkin]

Hey guys,

I now created separate directories for the iOS and OS X sample projects, they both use PocketSVG.h and PocketSVG.m which stays in the root directory.

Ariel