Retain CGColorRefs #115
Merged
Retain CGColorRefs #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjolnir
requested changes
Mar 19, 2018
SVGLayer.m
Outdated
| _fillColor = aColor; | ||
| CGColorRef previousColor = _fillColor; | ||
| _fillColor = CGColorRetain(aColor); | ||
| CGColorRelease(previousColor); |
There was a problem hiding this comment.
This is nitpicking, but I'm very allergic to unnecessary variables. And writing it like below would eliminate the need for one:
CGColorRetain(aColor);
CGColorRelease(_fillColor);
_fillColor = aColor;
cysp
force-pushed
the
bugfix/retain-cgcolors
branch
from
1914148
to
bcd84fa
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing some strange behaviour where setting the colours prior to loading an SVG seemed to just ignore any colours that I had set, but only for non-default colours (i.e. colours created from their rgb component values, not
UIColor.redColor).I tracked this down to the
CGColorRefobjects not being retained by these property setters.TBH I"m surprised that the result was just "not using the colour" rather than a crash of some description, but ¯\(ツ)/¯