Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recommendations #265

Merged
merged 13 commits into from
Apr 14, 2022
Merged

Feature/recommendations #265

merged 13 commits into from
Apr 14, 2022

Conversation

only1question
Copy link
Collaborator

Added methods for content and account recommendations

@only1question only1question added this to the v0.20.20 milestone Apr 11, 2022
@only1question only1question self-assigned this Apr 11, 2022
@only1question only1question linked an issue Apr 11, 2022 that may be closed by this pull request
@andyoknen andyoknen linked an issue Apr 11, 2022 that may be closed by this pull request
@only1question only1question linked an issue Apr 12, 2022 that may be closed by this pull request
@only1question only1question marked this pull request as ready for review April 12, 2022 15:37
@andyoknen andyoknen requested a review from tawmaz April 12, 2022 20:09
Copy link
Contributor

@tawmaz tawmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we done some performance testing on how long these queries take to complete? How about in extreme cases like if someone is following 1000+ accounts?

@only1question
Copy link
Collaborator Author

Have we done some performance testing on how long these queries take to complete? How about in extreme cases like if someone is following 1000+ accounts?

Calls limit the maximum number of subscribers to 100.
So far, only manual testing on several large and old accounts. Automatic will be implemented on the testnet when testing the version.

@only1question
Copy link
Collaborator Author

Have we done some performance testing on how long these queries take to complete? How about in extreme cases like if someone is following 1000+ accounts?

The last parameters limit the selection:

here

auto ids = request.DbConnection()->SearchRepoInst->GetRecommendedContentByAddressSubscriptions(address, addressExclude, contentTypes, lang, cntOut, chainActive.Height(), (60 * 24 * 30 * 3), 10);

and here
auto ids = request.DbConnection()->SearchRepoInst->GetRecommendedAccountByAddressSubscriptions(address, addressExclude, contentTypes, lang, cntOut, chainActive.Height(), (60 * 24 * 30 * 3), 10);

@andyoknen andyoknen merged commit c94c825 into 0.20 Apr 14, 2022
@andyoknen andyoknen deleted the feature/recommendations branch April 14, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

active actions on the content v0.20.20 Release Recommendations
4 participants