Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code 0 even if sudo password is not provided #3

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

HarimbolaSantatra
Copy link
Contributor

Issue

When installing using install.sh, if I don't provide password when moving the executable to the installation directory,

...
    if command -v sudo >/dev/null 2>&1; then
        sudo mv /tmp/pocketenv $INSTALL_DIR
...

, the script will continue, will print

Installation completed! 🎉
To get started, run:
pocketenv init

and will exit with status code 0, even if the executable will still be at /tmp/pocketenv and not at /usr/local/bin.

Solution

This PR adds the line set -e to solve this issue.

@tsirysndr tsirysndr merged commit f0c6648 into pocketenv-io:main Aug 18, 2024
@HarimbolaSantatra HarimbolaSantatra deleted the fix-install branch August 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants