-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support has_and_belongs_to_many #272
Open
tk0miya
wants to merge
1
commit into
pocke:master
Choose a base branch
from
tk0miya:support_habtm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Oct 31, 2023
Comment on lines
+144
to
+160
private def has_and_belongs_to_many | ||
klass.reflect_on_all_associations(:has_and_belongs_to_many).map do |a| | ||
@dependencies << a.klass.name | ||
|
||
singular_name = a.name.to_s.singularize | ||
type = Util.module_name(a.klass) | ||
collection_type = "#{type}::ActiveRecord_Associations_CollectionProxy" | ||
@dependencies << collection_type | ||
|
||
<<~RUBY.chomp | ||
def #{a.name}: () -> #{collection_type} | ||
def #{a.name}=: (#{collection_type} | ::Array[#{type}]) -> (#{collection_type} | ::Array[#{type}]) | ||
def #{singular_name}_ids: () -> ::Array[::Integer] | ||
def #{singular_name}_ids=: (::Array[::Integer]) -> ::Array[::Integer] | ||
RUBY | ||
end.join("\n") | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I duplicated #has_many
method and only modified the argument of klass.reflect_on_all_associations
.
tk0miya
force-pushed
the
support_habtm
branch
from
October 31, 2023 04:50
3215022
to
5b67ddf
Compare
tk0miya
added a commit
to tk0miya/conference-app
that referenced
this pull request
Nov 6, 2023
As a preparation of giving types to controllers, this adds types for `Profile#profile_badges` manually because current rbs_rails does not support HABTM association. It should be removed if rbs_rails will support it in the future. refs: pocke/rbs_rails#272
tk0miya
force-pushed
the
support_habtm
branch
from
November 10, 2024 15:32
5b67ddf
to
eedafdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.