Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darksky forecast date format #1

Closed
41south opened this issue Aug 28, 2018 · 13 comments
Closed

Darksky forecast date format #1

41south opened this issue Aug 28, 2018 · 13 comments
Assignees

Comments

@41south
Copy link

41south commented Aug 28, 2018

The Darksky forecast date format is currently US i.e. M/D Could there please be an option to change that to D/M for those of us down in the colonies using dd/mm/yy :)

@poblabs
Copy link
Owner

poblabs commented Aug 29, 2018

I've had this one on my list to mirror the way weewx's built in methods are done. Just haven't gotten around to it. Will take a look at it though!

@poblabs poblabs self-assigned this Aug 29, 2018
@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018

Reaching out for help on this. Here's the link for tracking.

https://groups.google.com/forum/#!topic/weewx-development/_K4AbWtbsog

@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018

Making headway on this. It will require a few custom label options (different than Extras).

Not sure the best approach.

e.g.
1 variable for all "Long dates" (December 22, 2018, 10:19 PM EST)
1 variable for all "short dates" (Dec 12/22)
and a couple variables in between for the mixed dates.

Or 1 variable for each time placement. Like "records_page" for all dates on records page. And "earthquake" specific to the earthquake box. and "darksky_header" specific to the darksky bar, and "last_updated" for the last updated time.

Thoughts?

@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018

Some progress though.

image

@sgrayban
Copy link

I like short dates but I'll take whatever comes my way !

@41south
Copy link
Author

41south commented Dec 28, 2018

If you're splitting it into 2 options I like the sound of the first one - long or short as appropriate

1 variable for all "Long dates" (December 22, 2018, 10:19 PM EST)
1 variable for all "short dates" (Dec 12/22)
and a couple variables in between for the mixed dates.

@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018 via email

@41south
Copy link
Author

41south commented Dec 28, 2018

Yeah agree that less is more - the only one I saw that was "wrong" (for us colonials) was the Darksky forecast date format. My records page and all of of the charts/graphs look just fine

@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018

I figure if I'm going to offer a way to localize one section of time, I might as well try for all of it and have a default format (which weewx offers built in).

@41south
Copy link
Author

41south commented Dec 28, 2018

True, that does make sense and should keep it easy and consistent 👍

@poblabs
Copy link
Owner

poblabs commented Dec 28, 2018

There's so many dates. MQTT timestamp, darksky, earthquake, sunrise/sunset, record snapshot, and the records page alone has 3 or 4 different formats for a date. Most of it I can leave alone, I think it really is the Month/Day that was messing you up.

I keep flip flopping in my head to do a "long_date" "short_date" and do my own best guess at what makes sense.

Or doing "earthquake_timestamp", "mqtt_timestamp", "records_page_timestamp"....

@poblabs
Copy link
Owner

poblabs commented Dec 29, 2018

According to the weewx developer thread I posted earlier, it's suggested I just let weewx handle all the dates as part of the built-in system. That's going to change some of the look and feel - hopefully not too bad

@poblabs
Copy link
Owner

poblabs commented Feb 5, 2019

I've been making a lot of progress with removing the hard-coded time and date formatting. Now most everything respects the station's locale. Still some work to go, but I am closing this issue because the DarkSky forecast formatting is resolved in the latest commit

There are a lot of changes that have been uploaded in the last few days. If you want to test your best bet is to backup the skins folder, download the Master ZIP file from this repo and upload the files to their proper homes.

It's still beta for the next couple of days, so let me know if you encounter any problems!

poblabs referenced this issue Feb 5, 2019
poblabs pushed a commit that referenced this issue Dec 24, 2020
Update with latest changes
poblabs pushed a commit that referenced this issue Dec 27, 2020
poblabs added a commit that referenced this issue Jan 17, 2021
…owing-undefined)

Essential fix #1 (visibility unit showing undefined)
poblabs pushed a commit that referenced this issue Aug 27, 2021
Add missing file copy for aeris-icon-list.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants