Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow enabling internal transactions for simple token transfers txs #2752

Merged

Conversation

ayrat555
Copy link
Contributor

@ayrat555 ayrat555 commented Oct 4, 2019

it was disabled in #1305.
Note that it's not applicable for parity. Because we fetch internal
transactions for it block by block so all internal transactions are
fetched.

fixes #2743

Changelog

  • allow enabling internal transactions for simple token transfers txs

it was disabled in #1305.
Note that it's not applicable for parity. Because we fetch internal
transactions for it block by block so all internal transactions are
fetched.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1e2095e1-f8ad-435d-a1a3-a09efac938ba

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 77.685%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain/import/runner/transactions.ex 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
apps/indexer/lib/indexer/fetcher/token.ex 1 80.0%
apps/indexer/lib/indexer/fetcher/token_balance.ex 2 87.88%
apps/indexer/lib/indexer/block/fetcher.ex 3 89.02%
Totals Coverage Status
Change from base Build 4e3eab63-b925-477a-be86-95ac7aceb201: -0.09%
Covered Lines: 5309
Relevant Lines: 6834

💛 - Coveralls

@vbaranov vbaranov merged commit cbe3b31 into master Oct 16, 2019
@vbaranov vbaranov deleted the ab-allow-enabling-internal-transaction-fetching-for-geth branch October 16, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal_transactions_indexed_at is filled but internal transactions are missing
4 participants