Don't fetch internal transactions for simple token transfers #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
zachdaniel
approved these changes
Jan 4, 2019
|
A couple cleanup items I noticed: |
|
@acravenho fixed those already in the force push right before your comment. |
KronicDeth
force-pushed
the
1303
branch
2 times, most recently
from
5ed00ab
to
2811d6c
Compare
|
These are the results after indexing Goerli on
|
|
@acravenho 2811d6c contains a fix where one of the returns was inverted due to the realtime logic returning the opposite value from the importer, since one is deciding whether to fetch and one is decide whether to mark them as already fetched. Please test against Goerli again with this version. |
Pull Request Test Coverage Report for Build 19cce54d-5d7d-4a4f-9125-9dc4930ed85d
💛 - Coveralls |
KronicDeth
force-pushed
the
1303
branch
2 times, most recently
from
62ce1db
to
a619247
Compare
acravenho
approved these changes
Jan 4, 2019
Resolves #1303 Don't fetch internal transactions for transactions that have token transfers from the logs if the status is `:ok` and the transaction did not create a contract.
ayrat555
added a commit
that referenced
this pull request
Oct 4, 2019
it was disabled in #1305. Note that it's not applicable for parity. Because we fetch internal transactions for it block by block so all internal transactions are fetched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1303
Changelog
Enhancements
:okand the transaction did not create a contract.