Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not update cache if no blocks were inserted #2736

Merged
merged 4 commits into from
Sep 26, 2019
Merged

Conversation

ayrat555
Copy link
Contributor

fixes

2019-09-25T10:32:09.995 application=indexer fetcher=block_catchup first_block_number=8617628 last_block_number=8617628 [error] ** (Enum.EmptyError) empty error
    (elixir) lib/enum.ex:1721: anonymous fn/0 in Enum.min_max_by/2
    (indexer) lib/indexer/block/fetcher.ex:188: Indexer.Block.Fetcher.update_block_cache/1
    (indexer) lib/indexer/block/fetcher.ex:177: Indexer.Block.Fetcher.fetch_and_import_range/2
    (indexer) lib/indexer/block/catchup/fetcher.ex:194: Indexer.Block.Catchup.Fetcher.fetch_and_import_range_from_sequence/3
    (elixir) lib/task/supervised.ex:90: Task.Supervised.invoke_mfa/2
    (elixir) lib/task/supervised.ex:35: Task.Supervised.reply/5
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

Changelog

  • do not update cache if no blocks were inserted

@coveralls
Copy link

coveralls commented Sep 25, 2019

Pull Request Test Coverage Report for Build 08abf312-f1b3-47d3-92ff-fb99bda497ef

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.489%

Totals Coverage Status
Change from base Build f778debe-ab2d-42cf-b671-d60e5a3436b3: 0.0%
Covered Lines: 5258
Relevant Lines: 6699

💛 - Coveralls

Copy link
Contributor

@pasqu4le pasqu4le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vbaranov vbaranov merged commit 2c4cac2 into master Sep 26, 2019
@vbaranov vbaranov deleted the ab-fix-empty-block branch September 26, 2019 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants