Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not update cache if no blocks were inserted #2736

Merged
merged 4 commits into from
Sep 26, 2019
Merged

do not update cache if no blocks were inserted #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
156c6ca
do not update cache if no blocks were inserted
ayrat555 Sep 25, 2019
17b3154
Merge branch 'master' into ab-fix-empty-block
ayrat555 Sep 25, 2019
3fa83fa
add CHANGELOG entry
ayrat555 Sep 25, 2019
4bd63ff
Merge branch 'master' into ab-fix-empty-block
vbaranov Sep 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- [#2663](https://github.com/poanetwork/blockscout/pull/2663) - Fetch address counters in parallel

### Fixes
- [#2736](https://github.com/poanetwork/blockscout/pull/2736) - do not update cache if no blocks were inserted
- [#2731](https://github.com/poanetwork/blockscout/pull/2731) - fix library verification
- [#2718](https://github.com/poanetwork/blockscout/pull/2718) - Include all addresses taking part in transactions in wallets' addresses counter
- [#2709](https://github.com/poanetwork/blockscout/pull/2709) - Fix stuck label and value for uncle block height
Expand Down
2 changes: 2 additions & 0 deletions apps/indexer/lib/indexer/block/fetcher.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ defmodule Indexer.Block.Fetcher do
end
end

defp update_block_cache([]), do: :ok

defp update_block_cache(blocks) when is_list(blocks) do
{min_block, max_block} = Enum.min_max_by(blocks, & &1.number)

Expand Down