make coinmarketcap's number of pages configurable #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vbaranov
approved these changes
Apr 22, 2019
Pull Request Test Coverage Report for Build 744e9f41-eebb-48f6-8972-7dd307e123a8
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3da6d5de-d469-41c6-b29c-1569c5e8828d
💛 - Coveralls |
vbaranov
reviewed
Apr 22, 2019
| @@ -38,7 +38,7 @@ defmodule Explorer.ExchangeRates.Source.CoinMarketCap do | |||
| "#{base_url()}/v1/ticker/?start=#{page - 1}00" | |||
| end | |||
|
|
|||
| def max_page_number, do: 10 | |||
| def max_page_number, do: config(:pages) || 10 | |||
There was a problem hiding this comment.
Btw, do we need to convert config(:pages) to integer here and do we need the second fallback to 10 at all?
There was a problem hiding this comment.
we don't need a fallback. value is converted to integer in config
zachdaniel
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We couldn't fetch coin price for some coins
Changelog