Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make coinmarketcap's number of pages configurable #1802

Merged
merged 4 commits into from
Apr 22, 2019
Merged

make coinmarketcap's number of pages configurable #1802

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da2c79d
make coinmarketcap's number of pages configurable
ayrat555 Apr 22, 2019
8e9529f
add CHANGELOG entry
ayrat555 Apr 22, 2019
9508771
Merge branch 'master' into ab-make-number-of-pages-of-coinmarketcap-c…
vbaranov Apr 22, 2019
480f1b6
Update coin_market_cap.ex
ayrat555 Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
- [#1790](https://github.com/poanetwork/blockscout/pull/1790) - fix constructor arguments verification
- [#1793](https://github.com/poanetwork/blockscout/pull/1793) - fix top nav autocomplete
- [#1795](https://github.com/poanetwork/blockscout/pull/1795) - fix line numbers for decompiled contracts
- [#1802](https://github.com/poanetwork/blockscout/pull/1802) - make coinmarketcap's number of pages configurable

### Chore

Expand Down
3 changes: 3 additions & 0 deletions apps/explorer/config/config.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ config :explorer,

config :explorer, Explorer.Counters.AverageBlockTime, enabled: true

config :explorer, Explorer.ExchangeRates.Source.CoinMarketCap,
pages: String.to_integer(System.get_env("COINMARKETCAP_PAGES") || "10")

balances_update_interval =
if System.get_env("ADDRESS_WITH_BALANCES_UPDATE_INTERVAL") do
case Integer.parse(System.get_env("ADDRESS_WITH_BALANCES_UPDATE_INTERVAL")) do
Expand Down
2 changes: 1 addition & 1 deletion apps/explorer/lib/explorer/exchange_rates/source/coin_market_cap.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ defmodule Explorer.ExchangeRates.Source.CoinMarketCap do
"#{base_url()}/v1/ticker/?start=#{page - 1}00"
end

def max_page_number, do: 10
def max_page_number, do: config(:pages) || 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555

Btw, do we need to convert config(:pages) to integer here and do we need the second fallback to 10 at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need a fallback. value is converted to integer in config


defp base_url do
config(:base_url) || "https://api.coinmarketcap.com"
Expand Down