Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GolangCI issue (errcheck and could not determine GOARCH and Go compiler) #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

po3rin
Copy link
Owner

@po3rin po3rin commented Oct 2, 2019

I fix issue #3

GOLANGCI_COM_RUN=1 golangci-lint run --out-format=json --issues-exit-code=0 --deadline=5m --new=false --new-from-rev= --new-from-patch=
    server/main.go:13: Error return value of `http.ListenAndServe` is not checked (errcheck)

@po3rin po3rin added the bug Something isn't working label Oct 2, 2019
@po3rin po3rin self-assigned this Oct 2, 2019
@po3rin po3rin changed the title fix ci (errcheck) error check for fix GolangCI issue (errcheck) Oct 2, 2019
@po3rin po3rin changed the title error check for fix GolangCI issue (errcheck) Add error check for fix GolangCI issue (errcheck) Oct 2, 2019
@po3rin
Copy link
Owner Author

po3rin commented Oct 2, 2019

next error

$ GOLANGCI_COM_RUN=1 golangci-lint run --out-format=json --issues-exit-code=0 --deadline=5m --new=false --new-from-rev= --new-from-patch=../changes.patch
    Running error: context loading failed: failed to load program with go/packages: could not determine GOARCH and Go compiler

@po3rin po3rin changed the title Add error check for fix GolangCI issue (errcheck) fix GolangCI issue (errcheck and could not determine GOARCH and Go compiler) Oct 2, 2019
@po3rin
Copy link
Owner Author

po3rin commented Oct 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant