fix: aiohttp 3.9 _writer can't await #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Bull <[email protected]>
|
Hi, Can any maintainer check this? This weekend if all goes according to plan aiohttp 3.9 will be released, and at that time this change will be necessary. |
pnuckowski
approved these changes
Nov 17, 2023
|
When could a new version with this correction be released? aiohttp 3.9 has already been released and I need this fix to be published in a release so I can update my systems. |
1 task
|
Can the new version of this be released? |
|
@pnuckowski If possible, please release it, I am an upcoming committer from Flyte, we need it. |
Ya esta publicada, la versión 0.7.6 |
ludwigschwardt
added a commit
to ska-sa/katsdpmodels
that referenced
this pull request
Sep 16, 2024
Now that docker-base has aiohttp 3.9.3, get the latest aioresponses. This fixes a bug that "object Mock can't be used in 'await' expression" (see pnuckowski/aioresponses#248), which affects the 7 unit tests in test_fetch_aiohttp using the `mock_aioresponses` fixture.
ludwigschwardt
added a commit
to ska-sa/katsdpmodels
that referenced
this pull request
Sep 16, 2024
Now that docker-base has aiohttp 3.9.3, get the latest aioresponses. This fixes a bug that "object Mock can't be used in 'await' expression" (see pnuckowski/aioresponses#248), which affects the 7 unit tests in test_fetch_aiohttp using the `mock_aioresponses` fixture. It seems that aioresponses 0.7.6 needs Python 3.7 while katsdpmodels itself still only requires Python 3.6. This discrepancy seems OK for now as the tests are run on Python 3.8 and soon the minimum version will be bumped anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem mentioned in bug #247 and aio-libs/aiohttp#7675 (comment)