Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced pkg_resources with packaging module #241

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

iamibi
Copy link
Contributor

@iamibi iamibi commented Jun 20, 2023

Fixes #240

The official documentation of pkg_resources displays a warning to not access it directly. Instead, using the packaging module for the same to achieve it.

@iamibi
Copy link
Contributor Author

iamibi commented Jun 20, 2023

@pnuckowski

@ImreC
Copy link

ImreC commented Jul 26, 2023

Running into this as well. Would be nice to merge this @pnuckowski

@luis-carlon
Copy link

🙏 @pnuckowski

@pnuckowski pnuckowski merged commit b444d72 into pnuckowski:master Aug 31, 2023
@iamibi iamibi deleted the remove-pkg-resource-uses branch September 26, 2023 18:56
@jonashaag
Copy link

The packaging module is missing from the list of dependencies.

@gaby
Copy link
Contributor

gaby commented Jan 12, 2024

@pnuckowski @iamibi packaging needed to be added as a dependency, package now fails to install

#250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing setuptools as dependency
6 participants