chore: use RequestInfo rather than a mock #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
- Coverage 62.94% 60.35% -2.6%
=========================================
Files 2 2
Lines 394 396 +2
=========================================
- Hits 248 239 -9
- Misses 146 157 +11
Continue to review full report at Codecov.
|
pnuckowski
reviewed
Feb 13, 2020
aioresponses/core.py
Outdated
| @@ -26,6 +26,8 @@ | |||
| merge_params, | |||
| normalize_url, | |||
| ) | |||
| if AIOHTTP_VERSION >= StrictVersion('3.1.0'): | |||
| from aiohttp import RequestInfo | |||
There was a problem hiding this comment.
from aiohttp import RequestInfo
in case of import error RequestInfo = Mock
hadrien
commented
Jan 12, 2021
pnuckowski
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.