Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 compatibility and missing dependency #7

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

aldro61
Copy link
Contributor

@aldro61 aldro61 commented Oct 10, 2017

Hi @pnpnpn!

Thanks for making your code open-source. I fixed a few issues that I encountered while trying dna2vec:

  1. Missing dependency: "logbook"
  2. Imported the "print_function" from the "future" module to ensure Python 2 compatibility in multi_k_model.py

Cheers,
Alex

@pnpnpn
Copy link
Owner

pnpnpn commented Oct 10, 2017

Lgtm. Thanks!

@pnpnpn pnpnpn merged commit 8d033e9 into pnpnpn:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants