Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend error message #60

Closed
wants to merge 1 commit into from
Closed

feat: extend error message #60

wants to merge 1 commit into from

Conversation

btea
Copy link
Member

@btea btea commented Dec 24, 2024

No description provided.

@zkochan
Copy link
Member

zkochan commented Dec 25, 2024

Can't we just throw the original error object instead of ENOENT? What error will be thrown in this case with my change: #61 ?

@btea
Copy link
Member Author

btea commented Dec 25, 2024

I ran the following code in the exFAT driver and the following is the error content captured.

const target = './src'
const link = './src-link'

symlinkDir(target, link).catch((error) => {
    console.log(error)
})

After the modification of #61, the error message thrown is as follows:

image

The current pr modification information throws an error as follows:

image

@zkochan
Copy link
Member

zkochan commented Dec 25, 2024

I merged my PR and I will do additional changes in pnpm/pnpm#8879. This PR is not needed.

@zkochan zkochan closed this Dec 25, 2024
@btea btea deleted the feat/extend-error-message branch December 26, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants