Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component "PropertyFieldSitePicker" #208

Merged
merged 2 commits into from
Nov 28, 2019
Merged

add component "PropertyFieldSitePicker" #208

merged 2 commits into from
Nov 28, 2019

Conversation

nsoeth
Copy link

@nsoeth nsoeth commented Nov 22, 2019

Q A
Bug fix? [ ]
New feature? [ x ]
New sample? [ ]

What's in this Pull Request?

A new control named "PropertyFieldSitePicker". This control allows the user to select one or multiple sites from the SharePoint Search API. Similar to the SitePicker in the official "News"-WebPart.

@msftclas
Copy link

msftclas commented Nov 22, 2019

CLA assistant check
All CLA requirements met.

@AJIXuMuK
Copy link
Collaborator

Hi @nsoeth,
Thank you for the great addition to the library!
Could you please also update documentation to add details about the new control?
The documentation is located in the same repo in docs\documentation\docs folder.

@nsoeth
Copy link
Author

nsoeth commented Nov 23, 2019

Hi, I will do it. Might take some time though since I hurt my wrist yesterday. But I will do it asap.

@nsoeth
Copy link
Author

nsoeth commented Nov 28, 2019

Hi @AJIXuMuK ,
Managed to write the docs (once mkdocs is set up, it is quite fun writing docs) and also fixed a minor "inconvenience" in the process. Hope this is ok.

@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Nov 28, 2019
@AJIXuMuK
Copy link
Collaborator

Thank you @nsoeth for the update!

@AJIXuMuK AJIXuMuK merged commit 952eb7f into pnp:dev Nov 28, 2019
@estruyf estruyf mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants