Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldChoiceGroupWithCallout: iconProps not working #154

Closed
1 of 3 tasks
spplante opened this issue Feb 3, 2019 · 3 comments
Closed
1 of 3 tasks

PropertyFieldChoiceGroupWithCallout: iconProps not working #154

spplante opened this issue Feb 3, 2019 · 3 comments

Comments

@spplante
Copy link
Contributor

spplante commented Feb 3, 2019

Category

  • Enhancement
  • Bug
  • Question

Version

1.13.1

Expected / Desired Behavior / Question

When using the PropertyFieldChoiceGroupWithCallout, specifying the iconProps property in combination with the officeFabricIconFontName should render choice buttons with an icon instead of a regular radio button, just like the OOTB PropertyPaneChoiceGroup

Observed Behavior

When using the iconProps as below, the choice group does render buttons instead of radio buttons, but the icon is missing, leaving empty choice buttons instead :

{
    key: 'Option1',
    text: 'Option #1',
    iconProps: {
        officeFabricIconFontName: 'BulletedList2'
    }
}, 

Steps to Reproduce

Use the PropertyFieldChoiceGroupWithCallout control and specify an option using the code below, and notice the icon missing :

{
    key: 'Option1',
    text: 'Option #1',
    iconProps: {
        officeFabricIconFontName: 'BulletedList2'
    }
}, 
AJIXuMuK added a commit to AJIXuMuK/sp-dev-fx-property-controls that referenced this issue Mar 2, 2019
@AJIXuMuK AJIXuMuK mentioned this issue Mar 2, 2019
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 2, 2019

Hi @spplante!
Thanks for reporting.
The fix has been made in #166

@spplante
Copy link
Contributor Author

spplante commented Mar 2, 2019

Awesome good work 👍

estruyf added a commit that referenced this issue May 17, 2019
@spplante
Copy link
Contributor Author

Just tested this and it works as expected 👍

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants