Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - missing translation keys #994

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

gautamdsheth
Copy link
Contributor

@gautamdsheth gautamdsheth commented Aug 18, 2021

Q A
Bug fix? [x]
New feature? [x]
New sample? [ ]
Related issues? fixes NA

What's in this Pull Request?

This PR adds the missing translation keys for non-English languages.

@joelfmrodrigues , @AJIXuMuK - this does sound like a big PR , looking at number of files. But it has only added missing translation keys, didn't delete any keys.

I just ran the translation script with my cognitive services key and it has added the missing keys, to view the changes maybe just use the ignore whitespaces option so that it only shows the changed values

@joelfmrodrigues
Copy link
Collaborator

Many thanks @gautamdsheth
I tried the view ignoring spaces and it definitely helps. Will try to review soon

@joelfmrodrigues
Copy link
Collaborator

@gautamdsheth Many thanks again for this and apologies for the delay...
I noticed that some entries were still not translated (for example MyTeamsMessageDontHaveTeams) so feel free to send a new pull request if you can :)
Merging this one - Thanks!

@joelfmrodrigues joelfmrodrigues merged commit 3e795c0 into pnp:dev Sep 2, 2021
@estruyf estruyf mentioned this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants