Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onNewTerm called when enter is pressed #967

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Conversation

DennisKuhn
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #966

Added the ability to react to the enter/return key being pressed while a new text is in the input field.

This consists of two parts:

  • The new eventHandler onNewTerm called when text is input field and return is pressed
  • TermPicker.clearDisplayValue to clear the input field the onNewTerm is used

@joelfmrodrigues
Copy link
Collaborator

@DennisKuhn many thanks, would you mind also adding the new property to documentation please?

@DennisKuhn
Copy link
Contributor Author

DennisKuhn commented Jul 23, 2021 via email

@DennisKuhn
Copy link
Contributor Author

@joelfmrodrigues done ;-)

@joelfmrodrigues joelfmrodrigues merged commit 21cad60 into pnp:dev Jul 27, 2021
@joelfmrodrigues
Copy link
Collaborator

@DennisKuhn many thanks! and apologies for the delay
This has now been merged and will be in the next release

@DennisKuhn
Copy link
Contributor Author

@joelfmrodrigues pleasure, Thanks a lot for merging :-)

@DennisKuhn DennisKuhn deleted the dev branch July 29, 2021 06:48
@estruyf estruyf mentioned this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants