Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fast-serve support. #916

Merged
merged 1 commit into from
May 26, 2021
Merged

Added fast-serve support. #916

merged 1 commit into from
May 26, 2021

Conversation

s-KaiNet
Copy link
Contributor

Q A
Bug fix?
New feature? ✔️
New sample?
Related issues?

What's in this Pull Request?

This PR adds fast-serve support to the repository. Works only for the latest 3.x and SPFx 1.12+.

I also changed the import statement in the ControlsTest.tsx from

import { Accordion } from "../../../";

to

import { Accordion } from "../../../controls/accordion";

because the initial version adds circular module imports and it creates issues for webpack build with TypeScript.
In fast-serve mode, the code compiles approx. 10x times faster.

@AJIXuMuK AJIXuMuK merged commit e645128 into pnp:dev May 26, 2021
@AJIXuMuK
Copy link
Collaborator

Thank you @s-KaiNet for the enhancement!

@AJIXuMuK AJIXuMuK added this to the 3.2.0 milestone May 26, 2021
@estruyf estruyf mentioned this pull request Jun 23, 2021
@s-KaiNet s-KaiNet deleted the fast-serve branch September 8, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants