Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest unit tests #834

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Jest unit tests #834

merged 2 commits into from
Mar 19, 2021

Conversation

mgwojciech
Copy link

Q A
Bug fix? [ ]
New feature? [x ]
New sample? [x ]
Related issues? fixes #X, partially #Y, mentioned in #Z

Hello,
I wish to introduce jest based unit tests for the project. I believe it's much faster than karma, easier to set up than karma,, it easily allows debug which can speed up development and of course it can serve as a great regression testing.
To run it run: npx jest (I didn't want to introduce new script in package.json before You would decide this is a way to go)

Additionaly I think this project may serve as a great sample for people who would like to start their adventure with unit testing SPFx.

Should You accept this PR I'll start writing more tests to increase the coverage.

Hope You will like it!

Marcin Wojciechowski added 2 commits March 16, 2021 18:46
@AJIXuMuK
Copy link
Collaborator

Hi @mgwojciech,
Thank you for the initiative!

I'm totally OK with using jest. So, feel free to add the coverage!

@AJIXuMuK AJIXuMuK merged commit e2520fc into pnp:dev Mar 19, 2021
@AJIXuMuK AJIXuMuK added this to the 2.6.0 milestone Mar 19, 2021
@estruyf estruyf mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants