[Treeview] Fix two potential null reference issues #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when expandToSelected == true but nothing has been passed to defaultSelectedKeys (it doesn't make much sense tocombine both properties like this BUT defaultSelectedKeys is not required thus this case should be properly handled) - when expandToSelected == true but somewhere in the tree, treeItem.children == null (which is normal when there aren't any children of this specific item)
|
Thank you @YannickRe for the PR! It has been merged and will be included in the next release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
A fix for two potential null reference issues:
expandToSelected == truebutdefaultSelectedKeys == null. This combination of properties does not make much sense : if you wantexpandToSelectedyou NEED values in defaultSelectedKeys, butdefaultSelectedKeysis not required thus this combination can happen and it breaks the control.expandToSelected == truebut somewhere in the tree there is atreeItem.children == null. You should setchildren == nullwhen you don't want the expand arrow to show, but it breaks in combination withexpandToSelection == true.This PR fixes both issues.