Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListView > stickyHeaderStyles with a Classname. #696

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

aaclage
Copy link
Contributor

@aaclage aaclage commented Oct 13, 2020

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues? fixes #693

What's in this Pull Request?

This pull Request fix the height of the ListView when stickyHeader is true.

By default when stickyHeader isselected, control pre defined height:50vh, this PR changed to max-height: 40vh that empty or Library with few documents will not appear with some much empty space and became User friendly when displaying data.

The freeze option continue available and more efficient, without additional controls and just css.

User Interface pollution:
image

Expected User Interface after PR:
image

@aaclage aaclage changed the title Fix stickyHeaderStyles with a Classname. Fix ListView > stickyHeaderStyles with a Classname. Oct 13, 2020
@AJIXuMuK AJIXuMuK merged commit 0702e96 into pnp:dev Oct 13, 2020
@AJIXuMuK
Copy link
Collaborator

Thanks @aaclage for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants