Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: additional check for OrgAssets HTTP request #514

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix: additional check for OrgAssets HTTP request #514

merged 1 commit into from
Mar 27, 2020

Conversation

gautamdsheth
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? NA

What's in this Pull Request?

While using the FilePicker control, if I have set the hideOrganisationalAssetTab value to true, even then an additional HTTP request is made.

This PR avoids that by making the HTTP request only when hideOrganisationalAssetTab value is set to false. Especially needed in case of OnPrem where we don't have this capability available.

@AJIXuMuK AJIXuMuK merged commit b491e9a into pnp:dev Mar 27, 2020
@AJIXuMuK AJIXuMuK added this to the 1.18.0 milestone Mar 27, 2020
@AJIXuMuK
Copy link
Collaborator

Great contribution @gautamdsheth! Thank you!
The PR has been merged and the fix is available in beta version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants