Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Field Renderer Optimization #50

Merged
merged 2 commits into from
Mar 12, 2018

Conversation

AJIXuMuK
Copy link
Collaborator

@AJIXuMuK AJIXuMuK commented Mar 7, 2018

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? no

What's in this Pull Request?

Lookup field rendering using FieldRendererHelper was optimized.
Previously, FieldRendererHelper was sending request to get url of Display form for the list that is referenced in the lookup first and only then rendered the Lookup.
Because of that there was a lag before lookup values are rendered in the cell.
But the Display form url is needed only if a user clicks on the Lookup value. It's not needed to render the values itself.
So, the code was changed to request the url from FieldLookupRenderer itself at the moment when a user clicks on the value.

@codecov-io
Copy link

codecov-io commented Mar 7, 2018

Codecov Report

Merging #50 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #50   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files          10       10           
  Lines         335      335           
  Branches       78       71    -7     
=======================================
  Hits          261      261           
  Misses         55       55           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cfa7ae...55e88b6. Read the comment docs.

@estruyf estruyf merged commit f004a95 into pnp:dev Mar 12, 2018
@estruyf
Copy link
Member

estruyf commented Mar 12, 2018

Thanks for the update. Will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants