Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#458 listPicker always return "test" when multiple allowed #460

Merged
merged 1 commit into from
Jan 15, 2020
Merged

#458 listPicker always return "test" when multiple allowed #460

merged 1 commit into from
Jan 15, 2020

Conversation

mgwojciech
Copy link

Q A
Bug fix? [ *]
New feature? [ ]
New sample? [ ]
Related issues? fixes #458

What's in this Pull Request?

Removed "test" from initial selection inListPicker.onChanged

@codecov-io
Copy link

Codecov Report

Merging #460 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #460   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      154      154           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df2b77...c3540d1. Read the comment docs.

@AJIXuMuK AJIXuMuK merged commit 6fdd7bb into pnp:dev Jan 15, 2020
@AJIXuMuK
Copy link
Collaborator

Thanks @mgwojciech for that fix! It'll be included in the next version. But you can test it in beta version right now.

@AJIXuMuK AJIXuMuK added this to the 1.17.0 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants